* [PATCH] omap4: fb: Adds missing display update call when panning
@ 2010-07-15 12:37 Mayuresh Janorkar
2010-07-15 12:48 ` Shilimkar, Santosh
2010-07-26 7:47 ` Tomi Valkeinen
0 siblings, 2 replies; 6+ messages in thread
From: Mayuresh Janorkar @ 2010-07-15 12:37 UTC (permalink / raw)
To: tomi.valkeinen; +Cc: linux-omap, Gustavo Diaz Prado, Mayuresh Janorkar
From: Gustavo Diaz Prado <x0083741@ti.com>
Adds the missing display update call when panning, this
is needed for the DSI panel when the auto-update feature is
not enabled.
Signed-off-by: Gustavo Diaz Prado <x0083741@ti.com>
Signed-off-by: Mayuresh Janorkar <mayur@ti.com>
---
drivers/video/omap2/omapfb/omapfb-main.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
index 4abb1d1..12d5382 100644
--- a/drivers/video/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/omap2/omapfb/omapfb-main.c
@@ -1068,7 +1068,8 @@ static int omapfb_pan_display(struct fb_var_screeninfo *var,
{
struct omapfb_info *ofbi = FB2OFB(fbi);
struct fb_var_screeninfo new_var;
- int r;
+ int r = 0;
+ struct omap_dss_device *display = fb2display(fbi);
DBG("pan_display(%d)\n", FB2OFB(fbi)->id);
@@ -1086,6 +1087,11 @@ static int omapfb_pan_display(struct fb_var_screeninfo *var,
r = omapfb_apply_changes(fbi, 0);
+ if (display && display->driver->update &&
+ display->driver->get_update_mode(display)
+ == OMAP_DSS_UPDATE_MANUAL)
+ display->driver->update(display, 0, 0, var->xres, var->yres);
+
omapfb_put_mem_region(ofbi->region);
return r;
--
1.5.4.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] omap4: fb: Adds missing display update call when panning
2010-07-15 12:37 [PATCH] omap4: fb: Adds missing display update call when panning Mayuresh Janorkar
@ 2010-07-15 12:48 ` Shilimkar, Santosh
2010-07-21 13:19 ` Janorkar, Mayuresh
2010-07-26 7:47 ` Tomi Valkeinen
1 sibling, 1 reply; 6+ messages in thread
From: Shilimkar, Santosh @ 2010-07-15 12:48 UTC (permalink / raw)
To: Janorkar, Mayuresh, tomi.valkeinen@nokia.com
Cc: linux-omap@vger.kernel.org, Diaz Prado, Gustavo
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Janorkar, Mayuresh
> Sent: Thursday, July 15, 2010 6:07 PM
> To: tomi.valkeinen@nokia.com
> Cc: linux-omap@vger.kernel.org; Diaz Prado, Gustavo; Janorkar, Mayuresh
> Subject: [PATCH] omap4: fb: Adds missing display update call when panning
>
> From: Gustavo Diaz Prado <x0083741@ti.com>
>
> Adds the missing display update call when panning, this
> is needed for the DSI panel when the auto-update feature is
> not enabled.
>
> Signed-off-by: Gustavo Diaz Prado <x0083741@ti.com>
> Signed-off-by: Mayuresh Janorkar <mayur@ti.com>
> ---
> drivers/video/omap2/omapfb/omapfb-main.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
> b/drivers/video/omap2/omapfb/omapfb-main.c
> index 4abb1d1..12d5382 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -1068,7 +1068,8 @@ static int omapfb_pan_display(struct
> fb_var_screeninfo *var,
> {
> struct omapfb_info *ofbi = FB2OFB(fbi);
> struct fb_var_screeninfo new_var;
> - int r;
> + int r = 0;
> + struct omap_dss_device *display = fb2display(fbi);
>
> DBG("pan_display(%d)\n", FB2OFB(fbi)->id);
>
> @@ -1086,6 +1087,11 @@ static int omapfb_pan_display(struct
> fb_var_screeninfo *var,
>
> r = omapfb_apply_changes(fbi, 0);
>
> + if (display && display->driver->update &&
> + display->driver->get_update_mode(display)
> + == OMAP_DSS_UPDATE_MANUAL)
If the display dereference is checked, there is no need to check the base
pointer (display), right ?
> + display->driver->update(display, 0, 0, var->xres, var->yres);
> +
> omapfb_put_mem_region(ofbi->region);
>
> return r;
> --
> 1.5.4.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] omap4: fb: Adds missing display update call when panning
2010-07-15 12:48 ` Shilimkar, Santosh
@ 2010-07-21 13:19 ` Janorkar, Mayuresh
0 siblings, 0 replies; 6+ messages in thread
From: Janorkar, Mayuresh @ 2010-07-21 13:19 UTC (permalink / raw)
To: Shilimkar, Santosh, tomi.valkeinen@nokia.com
Cc: linux-omap@vger.kernel.org, Diaz Prado, Gustavo
> -----Original Message-----
> From: Shilimkar, Santosh
> Sent: Thursday, July 15, 2010 6:19 PM
> To: Janorkar, Mayuresh; tomi.valkeinen@nokia.com
> Cc: linux-omap@vger.kernel.org; Diaz Prado, Gustavo
> Subject: RE: [PATCH] omap4: fb: Adds missing display update call when
> panning
>
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> > owner@vger.kernel.org] On Behalf Of Janorkar, Mayuresh
> > Sent: Thursday, July 15, 2010 6:07 PM
> > To: tomi.valkeinen@nokia.com
> > Cc: linux-omap@vger.kernel.org; Diaz Prado, Gustavo; Janorkar, Mayuresh
> > Subject: [PATCH] omap4: fb: Adds missing display update call when
> panning
> >
> > From: Gustavo Diaz Prado <x0083741@ti.com>
> >
> > Adds the missing display update call when panning, this
> > is needed for the DSI panel when the auto-update feature is
> > not enabled.
> >
> > Signed-off-by: Gustavo Diaz Prado <x0083741@ti.com>
> > Signed-off-by: Mayuresh Janorkar <mayur@ti.com>
> > ---
> > drivers/video/omap2/omapfb/omapfb-main.c | 8 +++++++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
> > b/drivers/video/omap2/omapfb/omapfb-main.c
> > index 4abb1d1..12d5382 100644
> > --- a/drivers/video/omap2/omapfb/omapfb-main.c
> > +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> > @@ -1068,7 +1068,8 @@ static int omapfb_pan_display(struct
> > fb_var_screeninfo *var,
> > {
> > struct omapfb_info *ofbi = FB2OFB(fbi);
> > struct fb_var_screeninfo new_var;
> > - int r;
> > + int r = 0;
> > + struct omap_dss_device *display = fb2display(fbi);
> >
> > DBG("pan_display(%d)\n", FB2OFB(fbi)->id);
> >
> > @@ -1086,6 +1087,11 @@ static int omapfb_pan_display(struct
> > fb_var_screeninfo *var,
> >
> > r = omapfb_apply_changes(fbi, 0);
> >
> > + if (display && display->driver->update &&
> > + display->driver->get_update_mode(display)
> > + == OMAP_DSS_UPDATE_MANUAL)
> If the display dereference is checked, there is no need to check the base
> pointer (display), right ?
[Mayuresh]: That's correct. I would take it into account.
> > + display->driver->update(display, 0, 0, var->xres, var->yres);
> > +
> > omapfb_put_mem_region(ofbi->region);
> >
> > return r;
> > --
> > 1.5.4.7
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
Are there any more comments?
If not can I resend the patch incorporating Santosh's comments?
-Thanks,
Mayuresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] omap4: fb: Adds missing display update call when panning
2010-07-15 12:37 [PATCH] omap4: fb: Adds missing display update call when panning Mayuresh Janorkar
2010-07-15 12:48 ` Shilimkar, Santosh
@ 2010-07-26 7:47 ` Tomi Valkeinen
2010-08-11 10:14 ` Janorkar, Mayuresh
1 sibling, 1 reply; 6+ messages in thread
From: Tomi Valkeinen @ 2010-07-26 7:47 UTC (permalink / raw)
To: ext Mayuresh Janorkar; +Cc: linux-omap@vger.kernel.org, Gustavo Diaz Prado
Hi,
On Thu, 2010-07-15 at 14:37 +0200, ext Mayuresh Janorkar wrote:
> From: Gustavo Diaz Prado <x0083741@ti.com>
>
> Adds the missing display update call when panning, this
> is needed for the DSI panel when the auto-update feature is
> not enabled.
The omapfb driver is not meant to make updates automatically, except on
a few special cases (currently on initialization and when unblanking).
It's the user space's responsibility to update the screen.
The reason for this should be obvious if you think of a use case where
you have, say, all 3 overlays on the LCD, and you want to pan all of
them.
Tomi
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] omap4: fb: Adds missing display update call when panning
2010-07-26 7:47 ` Tomi Valkeinen
@ 2010-08-11 10:14 ` Janorkar, Mayuresh
2010-08-16 13:40 ` Tomi Valkeinen
0 siblings, 1 reply; 6+ messages in thread
From: Janorkar, Mayuresh @ 2010-08-11 10:14 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-omap@vger.kernel.org, Diaz Prado, Gustavo
Hi Tomi,
Could you please provide me info on how to update the screen from user's space incase of manual update mode?
-Thanks,
Mayuresh
> -----Original Message-----
> From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> Sent: Monday, July 26, 2010 1:17 PM
> To: Janorkar, Mayuresh
> Cc: linux-omap@vger.kernel.org; Diaz Prado, Gustavo
> Subject: Re: [PATCH] omap4: fb: Adds missing display update call when
> panning
>
> Hi,
>
> On Thu, 2010-07-15 at 14:37 +0200, ext Mayuresh Janorkar wrote:
> > From: Gustavo Diaz Prado <x0083741@ti.com>
> >
> > Adds the missing display update call when panning, this
> > is needed for the DSI panel when the auto-update feature is
> > not enabled.
>
> The omapfb driver is not meant to make updates automatically, except on
> a few special cases (currently on initialization and when unblanking).
> It's the user space's responsibility to update the screen.
>
> The reason for this should be obvious if you think of a use case where
> you have, say, all 3 overlays on the LCD, and you want to pan all of
> them.
>
> Tomi
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] omap4: fb: Adds missing display update call when panning
2010-08-11 10:14 ` Janorkar, Mayuresh
@ 2010-08-16 13:40 ` Tomi Valkeinen
0 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2010-08-16 13:40 UTC (permalink / raw)
To: ext Janorkar, Mayuresh; +Cc: linux-omap@vger.kernel.org, Diaz Prado, Gustavo
Hi,
On Wed, 2010-08-11 at 12:14 +0200, ext Janorkar, Mayuresh wrote:
> Hi Tomi,
>
> Could you please provide me info on how to update the screen from user's space incase of manual update mode?
You can use OMAPFB_UPDATE_WINDOW ioctl.
Tomi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-16 13:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-15 12:37 [PATCH] omap4: fb: Adds missing display update call when panning Mayuresh Janorkar
2010-07-15 12:48 ` Shilimkar, Santosh
2010-07-21 13:19 ` Janorkar, Mayuresh
2010-07-26 7:47 ` Tomi Valkeinen
2010-08-11 10:14 ` Janorkar, Mayuresh
2010-08-16 13:40 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).