From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: "ext Taneja, Archit" <archit@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: DSS2: DSI: Check for TX FIFO emptiness when sending long packets
Date: Tue, 27 Jul 2010 10:16:32 +0300 [thread overview]
Message-ID: <1280214992.2427.33.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC3560870305FAB129@dbde02.ent.ti.com>
On Mon, 2010-07-26 at 13:18 +0200, ext Taneja, Archit wrote:
> I am not sure about this, it can be probably aligned with what is done in
> update_screen_l4(). I didn't exaclty get why you block till
> fifo_stalls > 0xfffff and if we can have a similar reasoning for send_long?
>
> It would be great though if we can make dsi_vc_send_long() configurable enough
> to be actually used in dsi_update_screen_l4(), because they both have enough
> common code beween them.
dsi_update_screen_l4() is quite old and unused code. I was mainly trying
out how CPU can be used for DSI transfer, and trying out different ways
to get better performance. You shouldn't look at it as any reference =).
The 0xfffff was just a random number to abort the transfer if it didn't
seem to go through. It worked for me, but probably won't work for other
cases.
I don't think that anyone really wants to update the screen with CPU, so
the code could even be removed.
Tomi
prev parent reply other threads:[~2010-07-27 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 9:28 DSS2: DSI: Check for TX FIFO emptiness when sending long packets Taneja, Archit
2010-07-26 10:20 ` Tomi Valkeinen
2010-07-26 11:18 ` Taneja, Archit
2010-07-27 7:16 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280214992.2427.33.camel@tubuntu.research.nokia.com \
--to=tomi.valkeinen@nokia.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).