From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: [PATCH resend] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() Date: Wed, 28 Jul 2010 11:51:58 +0530 Message-ID: <1280298118-4295-1-git-send-email-archit@ti.com> References: <'> Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:49401 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101Ab0G1GWJ (ORCPT ); Wed, 28 Jul 2010 02:22:09 -0400 In-Reply-To: <'> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: tomi.valkeinen@nokia.com Cc: linux-omap@vger.kernel.org, Archit Taneja In the function overlay_manager_store, the length of the string buf is used to comapre the 2 strings, there is a possibility of false positive match if buf is a prefix string of another manager. The use of sysfs_streq() fixes this. Signed-off-by: Archit Taneja --- drivers/video/omap2/dss/overlay.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/omap2/dss/overlay.c b/drivers/video/omap2/dss/overlay.c index 8233658..244dca8 --- a/drivers/video/omap2/dss/overlay.c +++ b/drivers/video/omap2/dss/overlay.c @@ -65,7 +65,7 @@ static ssize_t overlay_manager_store(struct omap_overlay *ovl, const char *buf, for (i = 0; i < omap_dss_get_num_overlay_managers(); ++i) { mgr = omap_dss_get_overlay_manager(i); - if (strncmp(buf, mgr->name, len) == 0) + if (sysfs_streq(buf, mgr->name)) break; mgr = NULL; -- 1.5.4.7