From: Tomi Valkeinen <tomi.valkeinen@Nokia.com>
To: ext archit taneja <archit@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store()
Date: Mon, 02 Aug 2010 16:26:47 +0300 [thread overview]
Message-ID: <1280755607.3436.48.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <1280754851-17077-1-git-send-email-archit@ti.com>
On Mon, 2010-08-02 at 15:14 +0200, ext archit taneja wrote:
> From: Archit Taneja <archit@ti.com>
>
> The function overlay_manager_store currently fails if the sysfs input is a
> prefix string of an existing overlay manager name. This occurs because strncmp
> compares the two strings only till the length of the input sysfs string. So a
> sysfs input "lcd" will match manager name "lcd2" which is incorrect behavior.
>
> The use of sysfs_streq here will prevent this false positive match to occur.
>
> Signed-off-by: Archit Taneja <archit@ti.com>
Looks good, thanks!
Tomi
prev parent reply other threads:[~2010-08-02 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 13:14 [PATCH v2] OMAP: DSS2: Replace strncmp() with sysfs_streq() in overlay_manager_store() archit taneja
2010-08-02 13:26 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280755607.3436.48.camel@tubuntu.research.nokia.com \
--to=tomi.valkeinen@nokia.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox