* Re: [PATCH 0/8]usb: musb:USB driver changes to use hwmod+ omap-device apis
2010-08-09 12:32 ` Cousson, Benoit
@ 2010-08-09 20:58 ` Kevin Hilman
2010-08-10 5:03 ` Kalliguddi, Hema
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2010-08-09 20:58 UTC (permalink / raw)
To: Cousson, Benoit
Cc: HEMA HK, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Felipe Balbi, Tony Lindgren
"Cousson, Benoit" <b-cousson@ti.com> writes:
> On 8/6/2010 5:54 PM, HEMA HK wrote:
>> From: Hema HK<hemahk@ti.com>
>>
>> Series of patches to port musb driver to use hwmod and runtime pm
>> APIs for OMAP4 and OMAP3.These patches are tested on OMAP4430SDP and
>> OMAP3630-ZOOM3 boards.
>>
>> The patch 1 and 2 are are the prerequisites for the hwmod changes.
>> Patch 6 is the OMAP3 offmode support patch.
>>
>> This patch series is generated on "origin/pm-wip/hwmods-omap4".
>>
>> Offmode is tested with origin/pm on omap3630 zoom3 board.
>
> The way you are submitting that series is quite confusing!
>
> You are mixing several numbering schemes and several series versions.
> If this is a V2, you have to resubmit everything with a V2, and you
> must include an history.
>
> [8/8] usb : musb:Using runtime pm apis for musb.
> [7/8] : Hwmod api changes
> [V2,6/8] usb: musb: Offmode fix for idle path
> [V2,4/8] usb : musb:Using omap_device_build for musb device registration
> [4/8] usb: musb: HWMOD database structures fixes OMAP4
> [V2,3/4] usb: musb: HWMOD database structures addition for OMAP3
> [2/8] usb: musb: Remove board_data parameter from musb_platform_init()
> [1/8] usb: musb: Adding names for IRQs in resource structure
>
>
> The cover letter does not contain the overall stat to summarize what
> files you are modifying.
Please consider using git-format-patch + git-send-email which will
automatically take care of many of the problems Benoit has pointed out.
Please see this wiki page for lots of useful suggestions:
http://wiki.omappedia.org/wiki/Releasing_to_Linux_kernel_using_patches_and_emails
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 0/8]usb: musb:USB driver changes to use hwmod+ omap-device apis
2010-08-09 12:32 ` Cousson, Benoit
2010-08-09 20:58 ` Kevin Hilman
@ 2010-08-10 5:03 ` Kalliguddi, Hema
1 sibling, 0 replies; 4+ messages in thread
From: Kalliguddi, Hema @ 2010-08-10 5:03 UTC (permalink / raw)
To: Cousson, Benoit
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Felipe Balbi, Tony Lindgren, Kevin Hilman
Hi,
>-----Original Message-----
>From: Cousson, Benoit
>Sent: Monday, August 09, 2010 6:02 PM
>To: Kalliguddi, Hema
>Cc: linux-usb@vger.kernel.org; linux-omap@vger.kernel.org;
>Felipe Balbi; Tony Lindgren; Kevin Hilman
>Subject: Re: [PATCH 0/8]usb: musb:USB driver changes to use
>hwmod+ omap-device apis
>
>On 8/6/2010 5:54 PM, HEMA HK wrote:
>> From: Hema HK<hemahk@ti.com>
>>
>> Series of patches to port musb driver to use hwmod and runtime pm
>> APIs for OMAP4 and OMAP3.These patches are tested on OMAP4430SDP and
>> OMAP3630-ZOOM3 boards.
>>
>> The patch 1 and 2 are are the prerequisites for the hwmod changes.
>> Patch 6 is the OMAP3 offmode support patch.
>>
>> This patch series is generated on "origin/pm-wip/hwmods-omap4".
>>
>> Offmode is tested with origin/pm on omap3630 zoom3 board.
>
>The way you are submitting that series is quite confusing!
>
>You are mixing several numbering schemes and several series versions.
>If this is a V2, you have to resubmit everything with a V2,
>and you must
>include an history.
>
>[8/8] usb : musb:Using runtime pm apis for musb.
>[7/8] : Hwmod api changes
>[V2,6/8] usb: musb: Offmode fix for idle path
>[V2,4/8] usb : musb:Using omap_device_build for musb device
>registration
>[4/8] usb: musb: HWMOD database structures fixes OMAP4
>[V2,3/4] usb: musb: HWMOD database structures addition for OMAP3
>[2/8] usb: musb: Remove board_data parameter from musb_platform_init()
>[1/8] usb: musb: Adding names for IRQs in resource structure
>
>
>The cover letter does not contain the overall stat to summarize what
>files you are modifying.
>
>Some spaces are missing after the ":" in the email subjects.
I will take care of this in the next st of patches.
Thanks,
Hema
>
>Regards,
>Benoit
>
^ permalink raw reply [flat|nested] 4+ messages in thread