Re: [PATCH 10/10] OMAP4: Add opp tables.

Kevin Hilman
2010-08-25T23:24:57Z

On Wed, 2010-08-25 at 16:15 -0700, Kevin Hilman wrote:
> Thara Gopinath <thara@ti.com> writes:
>
> > This patch adds OPP tables for OMAP4. A new file
> > opp44xx.c has been added to keep the OMAP4 opp tables
> > and the registeration of these tables with the generic
> > opp framework.
> >
> > Signed-off-by: Thara Gopinath <thara@ti.com>
> > ---
> > arch/arm/mach-omap2/Makefile | 2 +-
> > arch/arm/mach-omap2/opp44xx.h | 26 ++++++++++++
> > arch/arm/mach-omap2/opp44xx_data.c | 80 ++++++++++++++++++++++++++++++++++++
> > arch/arm/mach-omap2/pm.c | 6 ++-
> > 4 files changed, 112 insertions(+), 2 deletions(-)
> > create mode 100644 arch/arm/mach-omap2/opp44xx.h
> > create mode 100644 arch/arm/mach-omap2/opp44xx_data.c
> >
> > diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> > index d46fbec..ebe3f36 100644
> > --- a/arch/arm/mach-omap2/Makefile
> > +++ b/arch/arm/mach-omap2/Makefile
> > @@ -51,7 +51,7 @@ obj-$(CONFIG_ARCH_OMAP2) += pm24xx.o
> > obj-$(CONFIG_ARCH_OMAP2) += sleep24xx.o
> > obj-$(CONFIG_ARCH_OMAP3) += pm34xx.o sleep34xx.o voltage.o \
> > cpuidle34xx.o
> > -obj-$(CONFIG_ARCH_OMAP4) += pm44xx.o voltage.o
> > +obj-$(CONFIG_ARCH_OMAP4) += pm44xx.o voltage.o opp44xx_data.o
> > obj-$(CONFIG_PM_DEBUG) += pm-debug.o
> > obj-$(CONFIG_OMAP_SMARTREFLEX) += sr_device.o smartreflex.o
> > obj-$(CONFIG_OMAP_SMARTREFLEX_CLASS3) += smartreflex-class3.o
> > diff --git a/arch/arm/mach-omap2/opp44xx.h b/arch/arm/mach-omap2/opp44xx.h
> > new file mode 100644
> > index 0000000..2cae9f3
> > --- /dev/null
> > +++ b/arch/arm/mach-omap2/opp44xx.h
>
> We don't really a new OMAP4-specific header for this. Let's just rename
> omap3-opp.h to omap-opp.h and put both init functions there.
>
> I'll update the pm-opp branch accordingly.

s/pm-opp/pm-cpufreq/

Actually, what I did was drop the header all together and just add the
definition to pm.c.

Kevin