public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
	alsa-devel@alsa-project.org, Tony Lindgren <tony@atomide.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: McBSP: Fix static function warning
Date: Wed, 08 Sep 2010 12:14:59 +0100	[thread overview]
Message-ID: <1283944499.3097.98.camel@odin> (raw)
In-Reply-To: <1283916223-23567-1-git-send-email-manjugk@ti.com>

On Wed, 2010-09-08 at 08:53 +0530, G, Manjunath Kondaiah wrote:
> This patch fixes sparse warning due non declaration of static function
> 
> sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
> 
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: alsa-devel@alsa-project.org
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> 
> ---
>  sound/soc/omap/omap-mcbsp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index 86f2139..5768381 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -780,7 +780,7 @@ struct snd_soc_dai omap_mcbsp_dai[] = {
>  
>  EXPORT_SYMBOL_GPL(omap_mcbsp_dai);
>  
> -int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
> +static int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
>  			struct snd_ctl_elem_info *uinfo)
>  {
>  	struct soc_mixer_control *mc =

Applied.
Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

      parent reply	other threads:[~2010-09-08 11:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08  3:23 [PATCH] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
2010-09-08  6:03 ` Peter Ujfalusi
2010-09-08  7:28   ` Jarkko Nikula
2010-09-08  9:13 ` Mark Brown
2010-09-08 11:14 ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283944499.3097.98.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=nm@ti.com \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox