From: Felipe Balbi <balbi@ti.com>
To: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Cc: Jarkko Nikula <jhnikula@gmail.com>,
Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>
Subject: [RFT/PATCH 2/8] cbus: remove device_release completion
Date: Tue, 14 Sep 2010 11:30:10 +0300 [thread overview]
Message-ID: <1284453016-8295-3-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1284453016-8295-1-git-send-email-balbi@ti.com>
We don't do anything before releasing the device
so we might as well return as soon as possible.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/cbus/retu.c | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c
index bc81a9b..15368dc 100644
--- a/drivers/cbus/retu.c
+++ b/drivers/cbus/retu.c
@@ -56,8 +56,6 @@ static int retu_is_vilma;
static struct tasklet_struct retu_tasklet;
spinlock_t retu_lock = SPIN_LOCK_UNLOCKED;
-static struct completion device_release;
-
struct retu_irq_handler_desc {
int (*func)(unsigned long);
unsigned long arg;
@@ -491,11 +489,6 @@ static int __devexit retu_remove(struct platform_device *pdev)
return 0;
}
-static void retu_device_release(struct device *dev)
-{
- complete(&device_release);
-}
-
static struct platform_driver retu_driver = {
.probe = retu_probe,
.remove = __devexit_p(retu_remove),
@@ -507,9 +500,6 @@ static struct platform_driver retu_driver = {
static struct platform_device retu_device = {
.name = "retu",
.id = -1,
- .dev = {
- .release = retu_device_release,
- }
};
/**
@@ -525,8 +515,6 @@ static int __init retu_init(void)
machine_is_nokia_n810() || machine_is_nokia_n810_wimax()))
return -ENODEV;
- init_completion(&device_release);
-
ret = platform_driver_register(&retu_driver);
if (ret < 0)
return ret;
@@ -547,7 +535,6 @@ static void __exit retu_exit(void)
{
platform_device_unregister(&retu_device);
platform_driver_unregister(&retu_driver);
- wait_for_completion(&device_release);
}
subsys_initcall(retu_init);
--
1.7.3.rc0.35.g8ac8c
next prev parent reply other threads:[~2010-09-14 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 8:30 [RFT/PATCH 0/8] cbus patches Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 1/8] cbus: Fix compile by converting ioctl calls to unlocked_ioctl calls Felipe Balbi
2010-09-14 8:30 ` Felipe Balbi [this message]
2010-09-14 8:30 ` [RFT/PATCH 3/8] cbus: retu: pass irq number via struct resource Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 4/8] cbus: retu: avoid section mismatch Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 5/8] cbus: tahvo: usb: convert to platform_driver Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 6/8] cbus: tahvo: remove device_release Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 7/8] cbus: tahvo: pass irq via struct resource Felipe Balbi
2010-09-14 8:30 ` [RFT/PATCH 8/8] cbus: tahvo: avoid section mismatch Felipe Balbi
2010-09-17 0:09 ` [RFT/PATCH 0/8] cbus patches Tony Lindgren
2010-09-17 6:44 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284453016-8295-3-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox