From: Luciano Coelho <luciano.coelho@nokia.com>
To: ext Ohad Ben-Cohen <ohad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Chikkature Rajashekar Madhusudhan <madhu.cr@ti.com>,
San Mehat <san@google.com>,
"Quadros Roger (Nokia-MS/Helsinki)" <roger.quadros@nokia.com>,
Tony Lindgren <tony@atomide.com>,
Nicolas Pitre <nico@fluxnic.net>, Ido Yariv <ido@wizery.com>,
Kalle Valo <kalle.valo@iki.fi>,
Russell King <linux@arm.linux.org.uk>,
Vitaly Wool <vitalywool@gmail.com>,
"Paasikivi Teemu.3 (EXT-Ixonos/Tampere)"
<ext-teemu.3.paasikivi@nokia.com>
Subject: Re: [PATCH v6 01/17] wl12xx: make wl12xx.h common to both spi and sdio
Date: Thu, 16 Sep 2010 23:00:59 +0300 [thread overview]
Message-ID: <1284667259.8951.75.camel@powerslave> (raw)
In-Reply-To: <AANLkTinQ3EVOTjfnOy7EXP==b=tpSicDdokBAZ67Lc7O@mail.gmail.com>
On Thu, 2010-09-16 at 21:56 +0200, ext Ohad Ben-Cohen wrote:
> On Thu, Sep 16, 2010 at 8:35 PM, Luciano Coelho
> <luciano.coelho@nokia.com> wrote:
> > Acked-by: Luciano Coelho <luciano.coelho@nokia.com>
> >
> > I just wonder why the wl12xx.h move wasn't detected as a rename. Did
> > you forget to use the -M option in format-patch?
>
> I thought it's because I stripped the SPI_ from the
> #ifndef _LINUX_SPI_WL12XX_H, but it should be smarter than that.
> Probably the -M.
Yes, it is smarter than that. With small changes like this, -M will
still show it as a rename and show the diff instead of the whole file
-ed and +ed back ;)
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-09-16 20:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 23:22 [PATCH v6 0/7] native wl1271 support on ZOOM Ohad Ben-Cohen
2010-09-15 23:22 ` [PATCH v6 1/7] wl12xx: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen
2010-09-16 10:17 ` Teemu Paasikivi
2010-09-16 10:45 ` Ohad Ben-Cohen
[not found] ` <AANLkTikYd+TojQC-R+Vrdou6KSRwFNczBeTnsX7eTDn4-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-09-16 11:16 ` [PATCH v6 01/17] " Ohad Ben-Cohen
2010-09-16 11:50 ` [PATCH v6 1/7] " Ohad Ben-Cohen
[not found] ` <1284635762-12335-1-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-09-16 18:35 ` [PATCH v6 01/17] " Luciano Coelho
2010-09-16 19:56 ` Ohad Ben-Cohen
2010-09-16 20:00 ` Luciano Coelho [this message]
2010-09-16 20:46 ` Tony Lindgren
[not found] ` <1284592929-29616-1-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-09-15 23:22 ` [PATCH v6 2/7] wl1271: propagate set_power's return value Ohad Ben-Cohen
[not found] ` <1284592929-29616-3-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-09-16 19:40 ` Luciano Coelho
2010-09-16 19:53 ` Ohad Ben-Cohen
2010-09-16 19:56 ` Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284667259.8951.75.camel@powerslave \
--to=luciano.coelho@nokia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ext-teemu.3.paasikivi@nokia.com \
--cc=ido@wizery.com \
--cc=kalle.valo@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linville@tuxdriver.com \
--cc=madhu.cr@ti.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=tony@atomide.com \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).