[PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Hema HK]

Modified the Omap,Blackfin and Davinci board files to add the name of the IRQs
in the resource structures and musb driver to use the get_irq_byname() api to
get the mc and dma irq numbers instead of using the index as the order of
resource definition need not be always in order of device interrupt and
then dma interrupt

Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>

---
 arch/arm/mach-davinci/usb.c                |    2 ++
 arch/arm/mach-omap2/usb-musb.c             |    2 ++
 arch/blackfin/mach-bf527/boards/cm_bf527.c |    2 ++
 arch/blackfin/mach-bf527/boards/ezbrd.c    |    2 ++
 arch/blackfin/mach-bf527/boards/ezkit.c    |    2 ++
 arch/blackfin/mach-bf548/boards/cm_bf548.c |    2 ++
 arch/blackfin/mach-bf548/boards/ezkit.c    |    2 ++
 drivers/usb/musb/cppi_dma.c                |    2 +-
 drivers/usb/musb/musb_core.c               |    2 +-
 drivers/usb/musb/musbhsdma.c               |    2 +-
 10 files changed, 17 insertions(+), 3 deletions(-)

Index: linux-omap-pm/arch/arm/mach-davinci/usb.c
===================================================================
--- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c
+++ linux-omap-pm/arch/arm/mach-davinci/usb.c
@@ -64,10 +64,12 @@ static struct resource usb_resources[] =
 	{
 		.start          = IRQ_USBINT,
 		.flags          = IORESOURCE_IRQ,
+		.name		= "mc"
 	},
 	{
 		/* placeholder for the dedicated CPPI IRQ */
 		.flags          = IORESOURCE_IRQ,
+		.name		= "dma"
 	},
 };
 
Index: linux-omap-pm/arch/arm/mach-omap2/usb-musb.c
===================================================================
--- linux-omap-pm.orig/arch/arm/mach-omap2/usb-musb.c
+++ linux-omap-pm/arch/arm/mach-omap2/usb-musb.c
@@ -39,10 +39,12 @@ static struct resource musb_resources[] 
 	[1] = {	/* general IRQ */
 		.start	= INT_243X_HS_USB_MC,
 		.flags	= IORESOURCE_IRQ,
+		.name	= "mc",
 	},
 	[2] = {	/* DMA IRQ */
 		.start	= INT_243X_HS_USB_DMA,
 		.flags	= IORESOURCE_IRQ,
+		.name	= "dma",
 	},
 };
 
Index: linux-omap-pm/arch/blackfin/mach-bf527/boards/cm_bf527.c
===================================================================
--- linux-omap-pm.orig/arch/blackfin/mach-bf527/boards/cm_bf527.c
+++ linux-omap-pm/arch/blackfin/mach-bf527/boards/cm_bf527.c
@@ -82,11 +82,13 @@ static struct resource musb_resources[] 
 		.start	= IRQ_USB_INT0,
 		.end	= IRQ_USB_INT0,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "mc"
 	},
 	[2] = {	/* DMA IRQ */
 		.start	= IRQ_USB_DMA,
 		.end	= IRQ_USB_DMA,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "dma"
 	},
 };
 
Index: linux-omap-pm/arch/blackfin/mach-bf527/boards/ezbrd.c
===================================================================
--- linux-omap-pm.orig/arch/blackfin/mach-bf527/boards/ezbrd.c
+++ linux-omap-pm/arch/blackfin/mach-bf527/boards/ezbrd.c
@@ -46,11 +46,13 @@ static struct resource musb_resources[] 
 		.start	= IRQ_USB_INT0,
 		.end	= IRQ_USB_INT0,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "mc"
 	},
 	[2] = {	/* DMA IRQ */
 		.start	= IRQ_USB_DMA,
 		.end	= IRQ_USB_DMA,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "dma"
 	},
 };
 
Index: linux-omap-pm/arch/blackfin/mach-bf527/boards/ezkit.c
===================================================================
--- linux-omap-pm.orig/arch/blackfin/mach-bf527/boards/ezkit.c
+++ linux-omap-pm/arch/blackfin/mach-bf527/boards/ezkit.c
@@ -86,11 +86,13 @@ static struct resource musb_resources[] 
 		.start	= IRQ_USB_INT0,
 		.end	= IRQ_USB_INT0,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "mc"
 	},
 	[2] = {	/* DMA IRQ */
 		.start	= IRQ_USB_DMA,
 		.end	= IRQ_USB_DMA,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "dma"
 	},
 };
 
Index: linux-omap-pm/arch/blackfin/mach-bf548/boards/cm_bf548.c
===================================================================
--- linux-omap-pm.orig/arch/blackfin/mach-bf548/boards/cm_bf548.c
+++ linux-omap-pm/arch/blackfin/mach-bf548/boards/cm_bf548.c
@@ -482,11 +482,13 @@ static struct resource musb_resources[] 
 		.start	= IRQ_USB_INT0,
 		.end	= IRQ_USB_INT0,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "mc"
 	},
 	[2] = {	/* DMA IRQ */
 		.start	= IRQ_USB_DMA,
 		.end	= IRQ_USB_DMA,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "dma"
 	},
 };
 
Index: linux-omap-pm/arch/blackfin/mach-bf548/boards/ezkit.c
===================================================================
--- linux-omap-pm.orig/arch/blackfin/mach-bf548/boards/ezkit.c
+++ linux-omap-pm/arch/blackfin/mach-bf548/boards/ezkit.c
@@ -587,11 +587,13 @@ static struct resource musb_resources[] 
 		.start	= IRQ_USB_INT0,
 		.end	= IRQ_USB_INT0,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "mc"
 	},
 	[2] = {	/* DMA IRQ */
 		.start	= IRQ_USB_DMA,
 		.end	= IRQ_USB_DMA,
 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
+		.name	= "dma"
 	},
 };
 
Index: linux-omap-pm/drivers/usb/musb/cppi_dma.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/cppi_dma.c
+++ linux-omap-pm/drivers/usb/musb/cppi_dma.c
@@ -1307,7 +1307,7 @@ dma_controller_create(struct musb *musb,
 	struct cppi		*controller;
 	struct device		*dev = musb->controller;
 	struct platform_device	*pdev = to_platform_device(dev);
-	int			irq = platform_get_irq(pdev, 1);
+	int			irq = platform_get_irq_byname(pdev, "dma");
 
 	controller = kzalloc(sizeof *controller, GFP_KERNEL);
 	if (!controller)
Index: linux-omap-pm/drivers/usb/musb/musb_core.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
+++ linux-omap-pm/drivers/usb/musb/musb_core.c
@@ -2203,7 +2203,7 @@ static u64	*orig_dma_mask;
 static int __init musb_probe(struct platform_device *pdev)
 {
 	struct device	*dev = &pdev->dev;
-	int		irq = platform_get_irq(pdev, 0);
+	int		irq = platform_get_irq_byname(pdev, "mc");
 	int		status;
 	struct resource	*iomem;
 	void __iomem	*base;
Index: linux-omap-pm/drivers/usb/musb/musbhsdma.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/musbhsdma.c
+++ linux-omap-pm/drivers/usb/musb/musbhsdma.c
@@ -363,7 +363,7 @@ dma_controller_create(struct musb *musb,
 	struct musb_dma_controller *controller;
 	struct device *dev = musb->controller;
 	struct platform_device *pdev = to_platform_device(dev);
-	int irq = platform_get_irq(pdev, 1);
+	int irq = platform_get_irq_byname(pdev, "dma");
 
 	if (irq == 0) {
 		dev_err(dev, "No DMA interrupt line!\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Felipe Balbi]

On Wed, Sep 22, 2010 at 07:27:11PM -0500, Kalliguddi, Hema wrote:
>Modified the Omap,Blackfin and Davinci board files to add the name of the IRQs
>in the resource structures and musb driver to use the get_irq_byname() api to
>get the mc and dma irq numbers instead of using the index as the order of
>resource definition need not be always in order of device interrupt and
>then dma interrupt
>
>Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
>Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
>Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>

this is fine by me, but you need to Cc the other ARCH maintainers, Tony
can answer for OMAP and Kevin for DaVinci, but where's Blackfin's
maintainer ? Without all theirs ACKs for the arch-specific part, I can't
queue this to .37 and it's already quite late. If we don't get all
needed Acks by tomorrow, I doubt Greg will accept these for .37 merge
window.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Kalliguddi, Hema]

Hi, 

>-----Original Message-----
>From: Balbi, Felipe 
>Sent: Thursday, September 23, 2010 11:40 AM
>To: Kalliguddi, Hema
>Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; 
>Balbi, Felipe; Tony Lindgren; Kevin Hilman; Cousson, Benoit; 
>Paul Walmsley
>Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs 
>in resource structure
>
>On Wed, Sep 22, 2010 at 07:27:11PM -0500, Kalliguddi, Hema wrote:
>>Modified the Omap,Blackfin and Davinci board files to add the 
>name of the IRQs
>>in the resource structures and musb driver to use the 
>get_irq_byname() api to
>>get the mc and dma irq numbers instead of using the index as 
>the order of
>>resource definition need not be always in order of device 
>interrupt and
>>then dma interrupt
>>
>>Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
>>Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>>Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
>>Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>
>this is fine by me, but you need to Cc the other ARCH maintainers, Tony
>can answer for OMAP and Kevin for DaVinci, but where's Blackfin's
>maintainer ? Without all theirs ACKs for the arch-specific 
>part, I can't
>queue this to .37 and it's already quite late. If we don't get all
>needed Acks by tomorrow, I doubt Greg will accept these for .37 merge
>window.
>
I understand that. I forgot to Cc Mike for blackfin arch files change.
I will post it again today Cc ing him and try my luck :-)

~Hema
>-- 
>balbi
>--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Kalliguddi, Hema]

Hi Mike,

>-----Original Message-----
>From: Kalliguddi, Hema 
>Sent: Thursday, September 23, 2010 5:57 AM
>To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>Cc: Kalliguddi, Hema; Balbi, Felipe; Tony Lindgren; Kevin 
>Hilman; Cousson, Benoit; Paul Walmsley
>Subject: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in 
>resource structure
>
>Modified the Omap,Blackfin and Davinci board files to add the 
>name of the IRQs
>in the resource structures and musb driver to use the 
>get_irq_byname() api to
>get the mc and dma irq numbers instead of using the index as 
>the order of
>resource definition need not be always in order of device interrupt and
>then dma interrupt
>
>Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
>Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
>Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>
>---
> arch/arm/mach-davinci/usb.c                |    2 ++
> arch/arm/mach-omap2/usb-musb.c             |    2 ++
> arch/blackfin/mach-bf527/boards/cm_bf527.c |    2 ++
> arch/blackfin/mach-bf527/boards/ezbrd.c    |    2 ++
> arch/blackfin/mach-bf527/boards/ezkit.c    |    2 ++
> arch/blackfin/mach-bf548/boards/cm_bf548.c |    2 ++
> arch/blackfin/mach-bf548/boards/ezkit.c    |    2 ++
> drivers/usb/musb/cppi_dma.c                |    2 +-
> drivers/usb/musb/musb_core.c               |    2 +-
> drivers/usb/musb/musbhsdma.c               |    2 +-
> 10 files changed, 17 insertions(+), 3 deletions(-)
>
>Index: linux-omap-pm/arch/arm/mach-davinci/usb.c
>===================================================================
>--- linux-omap-pm.orig/arch/arm/mach-davinci/usb.c
>+++ linux-omap-pm/arch/arm/mach-davinci/usb.c
>@@ -64,10 +64,12 @@ static struct resource usb_resources[] =
> 	{
> 		.start          = IRQ_USBINT,
> 		.flags          = IORESOURCE_IRQ,
>+		.name		= "mc"
> 	},
> 	{
> 		/* placeholder for the dedicated CPPI IRQ */
> 		.flags          = IORESOURCE_IRQ,
>+		.name		= "dma"
> 	},
> };
> 
>Index: linux-omap-pm/arch/arm/mach-omap2/usb-musb.c
>===================================================================
>--- linux-omap-pm.orig/arch/arm/mach-omap2/usb-musb.c
>+++ linux-omap-pm/arch/arm/mach-omap2/usb-musb.c
>@@ -39,10 +39,12 @@ static struct resource musb_resources[] 
> 	[1] = {	/* general IRQ */
> 		.start	= INT_243X_HS_USB_MC,
> 		.flags	= IORESOURCE_IRQ,
>+		.name	= "mc",
> 	},
> 	[2] = {	/* DMA IRQ */
> 		.start	= INT_243X_HS_USB_DMA,
> 		.flags	= IORESOURCE_IRQ,
>+		.name	= "dma",
> 	},
> };
> 
>Index: linux-omap-pm/arch/blackfin/mach-bf527/boards/cm_bf527.c
>===================================================================
>--- linux-omap-pm.orig/arch/blackfin/mach-bf527/boards/cm_bf527.c
>+++ linux-omap-pm/arch/blackfin/mach-bf527/boards/cm_bf527.c
>@@ -82,11 +82,13 @@ static struct resource musb_resources[] 
> 		.start	= IRQ_USB_INT0,
> 		.end	= IRQ_USB_INT0,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "mc"
> 	},
> 	[2] = {	/* DMA IRQ */
> 		.start	= IRQ_USB_DMA,
> 		.end	= IRQ_USB_DMA,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "dma"
> 	},
> };
> 
>Index: linux-omap-pm/arch/blackfin/mach-bf527/boards/ezbrd.c
>===================================================================
>--- linux-omap-pm.orig/arch/blackfin/mach-bf527/boards/ezbrd.c
>+++ linux-omap-pm/arch/blackfin/mach-bf527/boards/ezbrd.c
>@@ -46,11 +46,13 @@ static struct resource musb_resources[] 
> 		.start	= IRQ_USB_INT0,
> 		.end	= IRQ_USB_INT0,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "mc"
> 	},
> 	[2] = {	/* DMA IRQ */
> 		.start	= IRQ_USB_DMA,
> 		.end	= IRQ_USB_DMA,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "dma"
> 	},
> };
> 
>Index: linux-omap-pm/arch/blackfin/mach-bf527/boards/ezkit.c
>===================================================================
>--- linux-omap-pm.orig/arch/blackfin/mach-bf527/boards/ezkit.c
>+++ linux-omap-pm/arch/blackfin/mach-bf527/boards/ezkit.c
>@@ -86,11 +86,13 @@ static struct resource musb_resources[] 
> 		.start	= IRQ_USB_INT0,
> 		.end	= IRQ_USB_INT0,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "mc"
> 	},
> 	[2] = {	/* DMA IRQ */
> 		.start	= IRQ_USB_DMA,
> 		.end	= IRQ_USB_DMA,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "dma"
> 	},
> };
> 
>Index: linux-omap-pm/arch/blackfin/mach-bf548/boards/cm_bf548.c
>===================================================================
>--- linux-omap-pm.orig/arch/blackfin/mach-bf548/boards/cm_bf548.c
>+++ linux-omap-pm/arch/blackfin/mach-bf548/boards/cm_bf548.c
>@@ -482,11 +482,13 @@ static struct resource musb_resources[] 
> 		.start	= IRQ_USB_INT0,
> 		.end	= IRQ_USB_INT0,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "mc"
> 	},
> 	[2] = {	/* DMA IRQ */
> 		.start	= IRQ_USB_DMA,
> 		.end	= IRQ_USB_DMA,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "dma"
> 	},
> };
> 
>Index: linux-omap-pm/arch/blackfin/mach-bf548/boards/ezkit.c
>===================================================================
>--- linux-omap-pm.orig/arch/blackfin/mach-bf548/boards/ezkit.c
>+++ linux-omap-pm/arch/blackfin/mach-bf548/boards/ezkit.c
>@@ -587,11 +587,13 @@ static struct resource musb_resources[] 
> 		.start	= IRQ_USB_INT0,
> 		.end	= IRQ_USB_INT0,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "mc"
> 	},
> 	[2] = {	/* DMA IRQ */
> 		.start	= IRQ_USB_DMA,
> 		.end	= IRQ_USB_DMA,
> 		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHLEVEL,
>+		.name	= "dma"
> 	},
> };
> 
>Index: linux-omap-pm/drivers/usb/musb/cppi_dma.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/cppi_dma.c
>+++ linux-omap-pm/drivers/usb/musb/cppi_dma.c
>@@ -1307,7 +1307,7 @@ dma_controller_create(struct musb *musb,
> 	struct cppi		*controller;
> 	struct device		*dev = musb->controller;
> 	struct platform_device	*pdev = to_platform_device(dev);
>-	int			irq = platform_get_irq(pdev, 1);
>+	int			irq = 
>platform_get_irq_byname(pdev, "dma");
> 
> 	controller = kzalloc(sizeof *controller, GFP_KERNEL);
> 	if (!controller)
>Index: linux-omap-pm/drivers/usb/musb/musb_core.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
>+++ linux-omap-pm/drivers/usb/musb/musb_core.c
>@@ -2203,7 +2203,7 @@ static u64	*orig_dma_mask;
> static int __init musb_probe(struct platform_device *pdev)
> {
> 	struct device	*dev = &pdev->dev;
>-	int		irq = platform_get_irq(pdev, 0);
>+	int		irq = platform_get_irq_byname(pdev, "mc");
> 	int		status;
> 	struct resource	*iomem;
> 	void __iomem	*base;
>Index: linux-omap-pm/drivers/usb/musb/musbhsdma.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/musbhsdma.c
>+++ linux-omap-pm/drivers/usb/musb/musbhsdma.c
>@@ -363,7 +363,7 @@ dma_controller_create(struct musb *musb,
> 	struct musb_dma_controller *controller;
> 	struct device *dev = musb->controller;
> 	struct platform_device *pdev = to_platform_device(dev);
>-	int irq = platform_get_irq(pdev, 1);
>+	int irq = platform_get_irq_byname(pdev, "dma");
> 
> 	if (irq == 0) {
> 		dev_err(dev, "No DMA interrupt line!\n");
>

I am sorry I forgot to Cc you when I posted the patch. Please provide your comments on the changes.

Regards,
Hema



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Felipe Balbi]

Hi,

On Thu, Sep 23, 2010 at 01:24:19AM -0500, Kalliguddi, Hema wrote:
>I understand that. I forgot to Cc Mike for blackfin arch files change.
>I will post it again today Cc ing him and try my luck :-)

let's hope for the best, but while at that, would you take care of the
comments on the other patches ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Kalliguddi, Hema]

Hi, 

>-----Original Message-----
>From: Balbi, Felipe 
>Sent: Thursday, September 23, 2010 12:21 PM
>To: Kalliguddi, Hema
>Cc: Balbi, Felipe; linux-omap@vger.kernel.org; 
>linux-usb@vger.kernel.org; Tony Lindgren; Kevin Hilman; 
>Cousson, Benoit; Paul Walmsley
>Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs 
>in resource structure
>
>Hi,
>
>On Thu, Sep 23, 2010 at 01:24:19AM -0500, Kalliguddi, Hema wrote:
>>I understand that. I forgot to Cc Mike for blackfin arch files change.
>>I will post it again today Cc ing him and try my luck :-)
>
>let's hope for the best, but while at that, would you take care of the
>comments on the other patches ?

I am trying my level best to incorporate all the comments today and post them.
>
>-- 
>balbi
>

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Mike Frysinger]

On Thu, Sep 23, 2010 at 02:32, Kalliguddi, Hema wrote:
>From: Kalliguddi, Hema
>>Modified the Omap,Blackfin and Davinci board files to add the
>>name of the IRQs
>>in the resource structures and musb driver to use the
>>get_irq_byname() api to
>>get the mc and dma irq numbers instead of using the index as
>>the order of

i dont see a problem with the existing code (going by index #), but i
dont really care either way

>>resource definition need not be always in order of device interrupt and
>>then dma interrupt

well, currently, your resource definition must always be in the order
of dev int and then dma int.  if it isnt, then i dont think musb is
going to work.

not sure why you wouldnt simply change your platform resources to
match the what the driver expects ...
-mike

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Paul Walmsley]

Hello Mike,

On Tue, 28 Sep 2010, Mike Frysinger wrote:

> well, currently, your resource definition must always be in the order
> of dev int and then dma int.  if it isnt, then i dont think musb is
> going to work.
> 
> not sure why you wouldnt simply change your platform resources to
> match the what the driver expects ...

The resource data is getting automatically populated from a set of data 
generated from TI's hardware database for the OMAP platform, at least.  
While we could hack in some exceptions to that tool to generate resources 
in a specific order, it seems less fragile to use the resource name 
instead.  That way, no matter what order the resources are generated, the 
driver should still work.


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Mike Frysinger]

On Tue, Sep 28, 2010 at 17:18, Paul Walmsley wrote:
> On Tue, 28 Sep 2010, Mike Frysinger wrote:
>> well, currently, your resource definition must always be in the order
>> of dev int and then dma int.  if it isnt, then i dont think musb is
>> going to work.
>>
>> not sure why you wouldnt simply change your platform resources to
>> match the what the driver expects ...
>
> The resource data is getting automatically populated from a set of data
> generated from TI's hardware database for the OMAP platform, at least.
> While we could hack in some exceptions to that tool to generate resources
> in a specific order, it seems less fragile to use the resource name
> instead.  That way, no matter what order the resources are generated, the
> driver should still work.

guessing you're not referring to a device tree setup, but something
even more convoluted ?

i'd highly suggest that this patch be resent with the info you've just
provided in its changelog so people can get a better understanding of
the "why" ... i'm not against the patch, it just seemed to be lacking
any background info
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Paul Walmsley]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1340 bytes --]

On Tue, 28 Sep 2010, Mike Frysinger wrote:

> On Tue, Sep 28, 2010 at 17:18, Paul Walmsley wrote:
> > On Tue, 28 Sep 2010, Mike Frysinger wrote:
> >> well, currently, your resource definition must always be in the order
> >> of dev int and then dma int.  if it isnt, then i dont think musb is
> >> going to work.
> >>
> >> not sure why you wouldnt simply change your platform resources to
> >> match the what the driver expects ...
> >
> > The resource data is getting automatically populated from a set of data
> > generated from TI's hardware database for the OMAP platform, at least.
> > While we could hack in some exceptions to that tool to generate resources
> > in a specific order, it seems less fragile to use the resource name
> > instead.  That way, no matter what order the resources are generated, the
> > driver should still work.
> 
> guessing you're not referring to a device tree setup, but something
> even more convoluted ?

No need to disparage it before you've seen it :-)

> i'd highly suggest that this patch be resent with the info you've just
> provided in its changelog so people can get a better understanding of
> the "why" ... i'm not against the patch, it just seemed to be lacking
> any background info

Hema, would you care to update the patch changelog accordingly?


- Paul

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Mike Frysinger]

On Tue, Sep 28, 2010 at 17:44, Paul Walmsley wrote:
> On Tue, 28 Sep 2010, Mike Frysinger wrote:
>> On Tue, Sep 28, 2010 at 17:18, Paul Walmsley wrote:
>> > On Tue, 28 Sep 2010, Mike Frysinger wrote:
>> >> well, currently, your resource definition must always be in the order
>> >> of dev int and then dma int.  if it isnt, then i dont think musb is
>> >> going to work.
>> >>
>> >> not sure why you wouldnt simply change your platform resources to
>> >> match the what the driver expects ...
>> >
>> > The resource data is getting automatically populated from a set of data
>> > generated from TI's hardware database for the OMAP platform, at least.
>> > While we could hack in some exceptions to that tool to generate resources
>> > in a specific order, it seems less fragile to use the resource name
>> > instead.  That way, no matter what order the resources are generated, the
>> > driver should still work.
>>
>> guessing you're not referring to a device tree setup, but something
>> even more convoluted ?
>
> No need to disparage it before you've seen it :-)

ah, but that's when i do my best work

>> i'd highly suggest that this patch be resent with the info you've just
>> provided in its changelog so people can get a better understanding of
>> the "why" ... i'm not against the patch, it just seemed to be lacking
>> any background info
>
> Hema, would you care to update the patch changelog accordingly?

i'll pre-ack that for the Blackfin changes ... or, if you split those
out, i can merge it separately for 2.6.37.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Kalliguddi, Hema]

 Hi,

>-----Original Message-----
>From: vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org [mailto:vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org] On 
>Behalf Of Mike Frysinger
>Sent: Wednesday, September 29, 2010 3:18 AM
>To: Paul Walmsley
>Cc: Kalliguddi, Hema; linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; 
>linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Balbi, Felipe; Tony Lindgren; Kevin 
>Hilman; Cousson, Benoit
>Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs 
>in resource structure
>
>On Tue, Sep 28, 2010 at 17:44, Paul Walmsley wrote:
>> On Tue, 28 Sep 2010, Mike Frysinger wrote:
>>> On Tue, Sep 28, 2010 at 17:18, Paul Walmsley wrote:
>>> > On Tue, 28 Sep 2010, Mike Frysinger wrote:
>>> >> well, currently, your resource definition must always be 
>in the order
>>> >> of dev int and then dma int.  if it isnt, then i dont 
>think musb is
>>> >> going to work.
>>> >>
>>> >> not sure why you wouldnt simply change your platform resources to
>>> >> match the what the driver expects ...
>>> >
>>> > The resource data is getting automatically populated from 
>a set of data
>>> > generated from TI's hardware database for the OMAP 
>platform, at least.
>>> > While we could hack in some exceptions to that tool to 
>generate resources
>>> > in a specific order, it seems less fragile to use the 
>resource name
>>> > instead.  That way, no matter what order the resources 
>are generated, the
>>> > driver should still work.
>>>
>>> guessing you're not referring to a device tree setup, but something
>>> even more convoluted ?
>>
>> No need to disparage it before you've seen it :-)
>
>ah, but that's when i do my best work
>
>>> i'd highly suggest that this patch be resent with the info 
>you've just
>>> provided in its changelog so people can get a better 
>understanding of
>>> the "why" ... i'm not against the patch, it just seemed to 
>be lacking
>>> any background info
>>
>> Hema, would you care to update the patch changelog accordingly?
>
>i'll pre-ack that for the Blackfin changes ... or, if you split those
>out, i can merge it separately for 2.6.37.

I will repost the patches today for blackfin and omap changes with the changelog
updated accordingly.

>-mike
>--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Felipe Balbi]

Hi,

On Tue, Sep 28, 2010 at 10:32:07PM -0500, Kalliguddi, Hema wrote:
>I will repost the patches today for blackfin and omap changes with the changelog
>updated accordingly.

Have you re-sent the patches ? I just want to know if we're gonna merge
it through Greg or the patch will be split and merged through ARCH
trees.

Each way if fine by me, but 2.6.37 is getting really close.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/9 v3] usb: musb: Adding names for IRQs in resource structure

[Kalliguddi, Hema]

Felipe,
 
>-----Original Message-----
>From: Balbi, Felipe 
>Sent: Wednesday, September 29, 2010 12:01 PM
>To: Kalliguddi, Hema
>Cc: Mike Frysinger; Paul Walmsley; linux-omap@vger.kernel.org; 
>linux-usb@vger.kernel.org; Balbi, Felipe; Tony Lindgren; Kevin 
>Hilman; Cousson, Benoit
>Subject: Re: [PATCH 1/9 v3] usb: musb: Adding names for IRQs 
>in resource structure
>
>Hi,
>
>On Tue, Sep 28, 2010 at 10:32:07PM -0500, Kalliguddi, Hema wrote:
>>I will repost the patches today for blackfin and omap changes 
>with the changelog
>>updated accordingly.
>
>Have you re-sent the patches ? I just want to know if we're gonna merge
>it through Greg or the patch will be split and merged through ARCH
>trees.
>
>Each way if fine by me, but 2.6.37 is getting really close.
>
Then I will send a patch with changelog updated soon.
>-- 
>balbi
>