From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Yanick Saugy <yanick.saugy@heig-vd.ch>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Rajkumar N <rajkumar.nagarajan@ti.com>
Subject: Re: [PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP
Date: Wed, 29 Sep 2010 10:35:32 +0300 [thread overview]
Message-ID: <1285745732.6574.130.camel@tubuntu.research.nokia.com> (raw)
In-Reply-To: <1285071690.1783.34.camel@A05BPC17>
Hi,
On Tue, 2010-09-21 at 14:21 +0200, ext Yanick Saugy wrote:
> The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
> configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
> (CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)
>
> Be aware of changing this PIN will probably disable the camera, because
> it was previously configured as a camera clock.
>
>
> Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>
>
> --- a/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 15:27:05.148399721 +0200
> +++ b/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 14:46:09.792900019 +0200
> @@ -71,6 +71,7 @@ static struct twl4030_platform_data zoom
>
> #ifdef CONFIG_OMAP_MUX
> static struct omap_board_mux board_mux[] __initdata = {
> + OMAP3_MUX(CAM_XCLKA, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
> { .reg_offset = OMAP_MUX_TERMINATOR },
> };
> #else
> @@ -82,6 +83,7 @@ static void __init omap_zoom2_init(void)
> omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
> zoom_peripherals_init();
> zoom_debugboard_init();
> + zoom_display_init(OMAP_DSS_VENC_TYPE_COMPOSITE);
> }
>
> static void __init omap_zoom2_map_io(void)
How did you create this patch? It doesn't look like standard one, and
git am chokes on it. Also, it doesn't apply to the latest linux tree, so
you need to rebase.
Tomi
next prev parent reply other threads:[~2010-09-29 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 12:43 LCD on Zoom2 dev board with DSS Yanick Saugy
2010-09-13 12:52 ` Felipe Balbi
2010-09-16 12:56 ` Yanick Saugy
2010-09-16 20:42 ` Tony Lindgren
2010-09-21 12:21 ` [PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP Yanick Saugy
2010-09-28 21:31 ` Tony Lindgren
2010-09-29 7:35 ` Tomi Valkeinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-24 1:00 Omar Ramirez Luna
2010-11-24 8:47 ` Tomi Valkeinen
2010-11-30 23:33 ` Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285745732.6574.130.camel@tubuntu.research.nokia.com \
--to=tomi.valkeinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=rajkumar.nagarajan@ti.com \
--cc=yanick.saugy@heig-vd.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).