public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Tony Lindgren <tony@atomide.com>, Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Dmitry Kasatkin <dmitry.kasatkin@nokia.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Omar Ramirez Luna <omar.ramirez@ti.com>,
	Suman Anna <s-anna@ti.com>, Paul Walmsley <paul@pwsan.com>,
	Benoit Cousson <b-cousson@ti.com>,
	"Govindraj.R" <govindraj.raja@ti.com>,
	C A Subramaniam <subramaniam.ca@ti.com>,
	linux-omap@vger.kernel.org
Subject: [PATCH 4/5] omap: mailbox: fix detection for previously supported chips
Date: Tue, 26 Oct 2010 16:53:03 -0500	[thread overview]
Message-ID: <1288129984-22957-5-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1288129984-22957-1-git-send-email-omar.ramirez@ti.com>

Fix the mailbox detection for OMAP3630 and 2430, also minor
cleanup on conditional ifdef's that could affect it.

Given that 2430 has an iva too include it, as the same steps
for omap3 apply.

Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---
 arch/arm/mach-omap2/mailbox.c |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index 61f2149..b8fd120 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -277,7 +277,7 @@ static struct omap_mbox_ops omap2_mbox_ops = {
 
 /* FIXME: the following structs should be filled automatically by the user id */
 
-#if defined(CONFIG_ARCH_OMAP3430) || defined(CONFIG_ARCH_OMAP2420)
+#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP2)
 /* DSP */
 static struct omap_mbox2_priv omap2_mbox_dsp_priv = {
 	.tx_fifo = {
@@ -302,7 +302,7 @@ struct omap_mbox mbox_dsp_info = {
 };
 #endif
 
-#if defined(CONFIG_ARCH_OMAP3430)
+#if defined(CONFIG_ARCH_OMAP3)
 struct omap_mbox *omap3_mboxes[] = { &mbox_dsp_info, NULL };
 #endif
 
@@ -390,15 +390,19 @@ static int __devinit omap2_mbox_probe(struct platform_device *pdev)
 
 	if (false)
 		;
-#if defined(CONFIG_ARCH_OMAP3430)
-	else if (cpu_is_omap3430()) {
+#if defined(CONFIG_ARCH_OMAP3)
+	else if (cpu_is_omap34xx()) {
 		list = omap3_mboxes;
 
 		list[0]->irq = platform_get_irq_byname(pdev, "dsp");
 	}
 #endif
-#if defined(CONFIG_ARCH_OMAP2420)
-	else if (cpu_is_omap2420()) {
+#if defined(CONFIG_ARCH_OMAP2)
+	else if (cpu_is_omap2430()) {
+		list = omap2_mboxes;
+
+		list[0]->irq = platform_get_irq_byname(pdev, "dsp");
+	} else if (cpu_is_omap2420()) {
 		list = omap2_mboxes;
 
 		list[0]->irq = platform_get_irq_byname(pdev, "dsp");
-- 
1.7.1


  parent reply	other threads:[~2010-10-26 22:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26 21:52 [PATCH 0/5] omap: mailbox: hwmod support and dependent cleanup patches Omar Ramirez Luna
2010-10-26 21:53 ` [PATCH 1/5] omap: mailbox: initial hwmod support for omap3 Omar Ramirez Luna
2010-10-27  5:07   ` Varadarajan, Charulatha
2010-10-27 11:50     ` Omar Ramirez Luna
2010-11-09 23:38   ` Kevin Hilman
2010-11-10  3:08     ` Ramirez Luna, Omar
2010-10-26 21:53 ` [PATCH 2/5] omap: mailbox: initial hwmod support for omap2 Omar Ramirez Luna
2010-10-27  5:07   ` Varadarajan, Charulatha
2010-10-26 21:53 ` [PATCH 3/5] omap: mailbox: add omap_device latency information Omar Ramirez Luna
2010-11-09 23:48   ` Kevin Hilman
2010-11-10  1:18     ` Felipe Contreras
2010-11-10  3:03     ` Ramirez Luna, Omar
2010-10-26 21:53 ` Omar Ramirez Luna [this message]
2010-10-27  5:06   ` [PATCH 4/5] omap: mailbox: fix detection for previously supported chips Varadarajan, Charulatha
2010-10-27  7:28     ` Felipe Contreras
2010-10-27  9:00       ` Grazvydas Ignotas
2010-10-27  9:46         ` Felipe Contreras
2010-10-26 21:53 ` [PATCH 5/5] omap: mailbox: remove unreachable return Omar Ramirez Luna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288129984-22957-5-git-send-email-omar.ramirez@ti.com \
    --to=omar.ramirez@ti.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=b-cousson@ti.com \
    --cc=dmitry.kasatkin@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=govindraj.raja@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=s-anna@ti.com \
    --cc=subramaniam.ca@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox