public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-arm <linux-arm-kernel@lists.infradead.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"Palande Ameya (Nokia-MS/Helsinki)" <ameya.palande@nokia.com>,
	"mike@compulab.co.il" <mike@compulab.co.il>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 2/2] omap: rx51: mark reserved memory earlier
Date: Fri, 12 Nov 2010 15:28:12 +0200	[thread overview]
Message-ID: <1289568492.3297.277.camel@tubuntu> (raw)
In-Reply-To: <1287146784-5517-2-git-send-email-felipe.contreras@gmail.com>

Hi,

On Fri, 2010-10-15 at 14:46 +0200, ext Felipe Contreras wrote:
> So that omap_vram_set_sdram_vram() is called before
> omap_vram_reserve_sdram_memblock().

Is this still valid after the latest memblock stuff? I presume it is.
I'm not able to test this, and you said you didn't test it, so I'm a bit
uneasy about applying =).

 Tomi


> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  arch/arm/mach-omap2/board-rx51.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
> index a58e8cb..861079b 100644
> --- a/arch/arm/mach-omap2/board-rx51.c
> +++ b/arch/arm/mach-omap2/board-rx51.c
> @@ -144,17 +144,22 @@ static void __init rx51_init(void)
>  static void __init rx51_map_io(void)
>  {
>  	omap2_set_globals_3xxx();
> -	rx51_video_mem_init();
>  	omap34xx_map_common_io();
>  }
>  
> +static void __init rx51_reserve(void)
> +{
> +	rx51_video_mem_init();
> +	omap_reserve();
> +}
> +
>  MACHINE_START(NOKIA_RX51, "Nokia RX-51 board")
>  	/* Maintainer: Lauri Leukkunen <lauri.leukkunen@nokia.com> */
>  	.phys_io	= 0x48000000,
>  	.io_pg_offst	= ((0xfa000000) >> 18) & 0xfffc,
>  	.boot_params	= 0x80000100,
>  	.map_io		= rx51_map_io,
> -	.reserve	= omap_reserve,
> +	.reserve	= rx51_reserve,
>  	.init_irq	= rx51_init_irq,
>  	.init_machine	= rx51_init,
>  	.timer		= &omap_timer,



  parent reply	other threads:[~2010-11-12 13:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-16 12:48 DSS2 broken with 36-rc1 Ameya Palande
2010-08-16 12:59 ` Pawel Moll
2010-08-16 13:05   ` Ameya Palande
2010-08-23  6:46 ` Mike Rapoport
2010-08-23  7:06   ` Mike Rapoport
2010-08-25  0:21     ` Laine Walker-Avina
2010-08-25  8:05     ` Tomi Valkeinen
2010-08-25  8:47       ` Shilimkar, Santosh
2010-08-25  9:21       ` Grazvydas Ignotas
2010-08-25 11:43         ` Tomi Valkeinen
2010-08-25 18:51           ` Russell King - ARM Linux
2010-08-23  7:15   ` Tomi Valkeinen
2010-08-23  7:19     ` Mike Rapoport
2010-08-23  7:35       ` Tomi Valkeinen
2010-08-23  8:51         ` Mike Rapoport
2010-08-25  8:09           ` Tomi Valkeinen
2010-10-15 12:44             ` Felipe Contreras
2010-10-15 12:46               ` [PATCH 1/2] video: omap: vram: remove from normal memory Felipe Contreras
2010-10-18 13:10                 ` Tomi Valkeinen
2010-10-18 14:03                   ` Tomi Valkeinen
2010-10-18 22:55                     ` Tony Lindgren
2010-10-19  7:27                       ` Felipe Contreras
2010-10-19 12:03                       ` Tomi Valkeinen
2010-11-07 22:49                         ` Felipe Contreras
2010-11-08 11:40                           ` Tomi Valkeinen
2010-10-15 12:46               ` [PATCH 2/2] omap: rx51: mark reserved memory earlier Felipe Contreras
2010-10-15 12:49                 ` Felipe Contreras
2010-11-12 13:28                 ` Tomi Valkeinen [this message]
2011-02-10 14:40                   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289568492.3297.277.camel@tubuntu \
    --to=tomi.valkeinen@nokia.com \
    --cc=ameya.palande@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mike@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox