[PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[Yanick Saugy]

The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
(CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)

Be aware of changing this PIN will probably disable the camera, because
it was previously configured as a camera clock.


Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>

--- a/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 15:27:05.148399721 +0200
+++ b/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 14:46:09.792900019 +0200
@@ -71,6 +71,7 @@ static struct twl4030_platform_data zoom
 
 #ifdef CONFIG_OMAP_MUX
 static struct omap_board_mux board_mux[] __initdata = {
+   OMAP3_MUX(CAM_XCLKA, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
    { .reg_offset = OMAP_MUX_TERMINATOR },
 };
 #else
@@ -82,6 +83,7 @@ static void __init omap_zoom2_init(void)
    omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
    zoom_peripherals_init();
    zoom_debugboard_init();
+    zoom_display_init(OMAP_DSS_VENC_TYPE_COMPOSITE);
 }
 
 static void __init omap_zoom2_map_io(void)

Re: [PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[Tony Lindgren]

* Yanick Saugy <yanick.saugy@heig-vd.ch> [100921 05:13]:
> The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
> configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
> (CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)
> 
> Be aware of changing this PIN will probably disable the camera, because
> it was previously configured as a camera clock.
> 
> 
> Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>

I'm assuming Tomi is queuing this.

Acked-by: Tony Lindgren <tony@atomide.com>

> 
> --- a/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 15:27:05.148399721 +0200
> +++ b/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 14:46:09.792900019 +0200
> @@ -71,6 +71,7 @@ static struct twl4030_platform_data zoom
>  
>  #ifdef CONFIG_OMAP_MUX
>  static struct omap_board_mux board_mux[] __initdata = {
> +   OMAP3_MUX(CAM_XCLKA, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
>     { .reg_offset = OMAP_MUX_TERMINATOR },
>  };
>  #else
> @@ -82,6 +83,7 @@ static void __init omap_zoom2_init(void)
>     omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>     zoom_peripherals_init();
>     zoom_debugboard_init();
> +    zoom_display_init(OMAP_DSS_VENC_TYPE_COMPOSITE);
>  }
>  
>  static void __init omap_zoom2_map_io(void)
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[Tomi Valkeinen]

Hi,

On Tue, 2010-09-21 at 14:21 +0200, ext Yanick Saugy wrote:
> The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
> configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
> (CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)
> 
> Be aware of changing this PIN will probably disable the camera, because
> it was previously configured as a camera clock.
> 
> 
> Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>
> 
> --- a/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 15:27:05.148399721 +0200
> +++ b/arch/arm/mach-omap2/board-zoom2.c 2010-09-15 14:46:09.792900019 +0200
> @@ -71,6 +71,7 @@ static struct twl4030_platform_data zoom
>  
>  #ifdef CONFIG_OMAP_MUX
>  static struct omap_board_mux board_mux[] __initdata = {
> +   OMAP3_MUX(CAM_XCLKA, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
>     { .reg_offset = OMAP_MUX_TERMINATOR },
>  };
>  #else
> @@ -82,6 +83,7 @@ static void __init omap_zoom2_init(void)
>     omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>     zoom_peripherals_init();
>     zoom_debugboard_init();
> +    zoom_display_init(OMAP_DSS_VENC_TYPE_COMPOSITE);
>  }
>  
>  static void __init omap_zoom2_map_io(void)

How did you create this patch? It doesn't look like standard one, and
git am chokes on it. Also, it doesn't apply to the latest linux tree, so
you need to rebase.

 Tomi

[PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[Omar Ramirez Luna]

From: Yanick Saugy <yanick.saugy@heig-vd.ch>

The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
(CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)

Be aware of changing this PIN will probably disable the camera, because
it was previously configured as a camera clock.

Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
---

I'm not sure if this patch was forgotten, hence resending. Without
it, a blanks screen is seen on zoom2 board.

Original patch:
http://patchwork.kernel.org/patch/196922/

 arch/arm/mach-omap2/board-zoom2.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/board-zoom2.c b/arch/arm/mach-omap2/board-zoom2.c
index 1cd6414..8fe578c 100644
--- a/arch/arm/mach-omap2/board-zoom2.c
+++ b/arch/arm/mach-omap2/board-zoom2.c
@@ -51,6 +51,8 @@ static struct omap_board_mux board_mux[] __initdata = {
 	OMAP3_MUX(ETK_D4, OMAP_MUX_MODE2 | OMAP_PIN_INPUT_PULLUP),
 	OMAP3_MUX(ETK_D5, OMAP_MUX_MODE2 | OMAP_PIN_INPUT_PULLUP),
 	OMAP3_MUX(ETK_D6, OMAP_MUX_MODE2 | OMAP_PIN_INPUT_PULLUP),
+	/* LCD Panel reset (PROD) - GPIO 96 */
+	OMAP3_MUX(CAM_XCLKA, OMAP_MUX_MODE4 | OMAP_PIN_OUTPUT),
 	{ .reg_offset = OMAP_MUX_TERMINATOR },
 };
 #else
-- 
1.7.1

Re: [PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[Tomi Valkeinen]

Hi,

On Tue, 2010-11-23 at 19:00 -0600, ext Omar Ramirez Luna wrote:
> From: Yanick Saugy <yanick.saugy@heig-vd.ch>
> 
> The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
> configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
> (CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)
> 
> Be aware of changing this PIN will probably disable the camera, because
> it was previously configured as a camera clock.
> 
> Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>
> Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> ---
> 
> I'm not sure if this patch was forgotten, hence resending. Without
> it, a blanks screen is seen on zoom2 board.

Yes, I seem to have missed this.

But I'm a bit confused. You say that this will disable camera. Is there
a camera connected to the board, and it won't work after this? 

 Tomi

Re: [PATCH] OMAP: ZOOM2: Change GPIO to enable LCD NEC NL8048HL11-01B on OMAP34x-II MDP

[Ramirez Luna, Omar]

On Wed, Nov 24, 2010 at 2:47 AM, Tomi Valkeinen
<tomi.valkeinen@nokia.com> wrote:
> Hi,
>
> On Tue, 2010-11-23 at 19:00 -0600, ext Omar Ramirez Luna wrote:
>> From: Yanick Saugy <yanick.saugy@heig-vd.ch>
>>
>> The PIN which controls LCD's reset signal (VGA_nRESET/h_GPIO_96) was not
>> configured as a GPIO. We had to modify the OMAP MUX, and select this PIN
>> (CAM_XCLKA) as an output GPIO (OMAP_MUX_MODE4). (kernel 2.6.35)
>>
>> Be aware of changing this PIN will probably disable the camera, because
>> it was previously configured as a camera clock.
>>
>> Signed-off-by: Yanick Saugy <yanick.saugy@heig-vd.ch>
>> Acked-by: Tony Lindgren <tony@atomide.com>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>> ---
>>
>> I'm not sure if this patch was forgotten, hence resending. Without
>> it, a blanks screen is seen on zoom2 board.
>
> Yes, I seem to have missed this.
>
> But I'm a bit confused. You say that this will disable camera. Is there
> a camera connected to the board, and it won't work after this?

I'm not quite familiar with the camera, but will try to check it
(might take some time).

Yes, there is a camera module connected to zoom2 board, but I don't
know for sure if both share this pin (which at least from author's
comment and existing code appears to be the case).

Regards,

Omar