From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: DSS2: Clean up DISPC color mode validation checks
Date: Fri, 26 Nov 2010 12:33:38 +0200 [thread overview]
Message-ID: <1290767618.5382.31.camel@nubuntu> (raw)
In-Reply-To: <1290688090-27319-1-git-send-email-archit@ti.com>
Hi,
On Thu, 2010-11-25 at 17:58 +0530, ext Archit Taneja wrote:
> The supported set of color modes varies for different DISPC pipelines(plane)
> and omap version. This makes the checks for validation of a color mode more
> complicated as new omap versions are added.
>
> A dss_feature function is created which tells if a color_mode is supported
> for a plane on the current omap revision.
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> drivers/video/omap2/dss/dispc.c | 53 +++-----------------------------
> drivers/video/omap2/dss/dss_features.c | 7 ++++
> drivers/video/omap2/dss/dss_features.h | 2 +
> 3 files changed, 14 insertions(+), 48 deletions(-)
Looks good to me, thanks!
Tomi
prev parent reply other threads:[~2010-11-26 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 12:28 [PATCH] OMAP: DSS2: Clean up DISPC color mode validation checks Archit Taneja
2010-11-26 10:33 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290767618.5382.31.camel@nubuntu \
--to=tomi.valkeinen@nokia.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox