RE: [PATCH v5 3/7] OMAP: DSS2: Introduce omap_channel as a omap_dss_device parameter

[Tomi Valkeinen <tomi.valkeinen@nokia.com>]

On Thu, 2010-12-02 at 15:17 +0530, ext Taneja, Archit wrote:
> Hi,

> > If you can split this patch into the two parts I suggested
> > (if that's ok for you, you didn't comment on that one), and
> > check if there's anything to add to the commit descriptions,
> > I think we can go and apply this patch set.
> 
> If I split this into 2 parts, the first patch will be just a line
> addition in display.h, I was beaten up by the community because of
> this in the previous version. One line patches in a series aren't
> taken very kindly :|. What I can do is clearly mention the 2 sets
> of things which this commit does, if you think that is good enough.

Ah, hmm... I thought this patch also changed dss_recheck_connections()
to use the new field, but now that I look at it, it doesn't. Why do you
add the new channel-member here, if it's not used? Shouldn't it be added
later, together with dss_recheck_connections()?
 
> > Btw, on what platforms have you tested this (or generally any
> > patches you send?). I only have 3430SDP currently that I can
> > easily use to test, so my testing is a bit limited.
> > 
> 
> This one I had tested throughly on 3430SDP, bootup on zoom2 and zoom3.
> I couldn't test on omap2, we have a n800 board but we don't know what panel
> driver we need to use, board-n8x0.c doesn't tell anything about. If you can
> tell me what panel driver to use etc I can try out.

Unfortunately the panel driver for N800 has not been ported to DSS2.

 Tomi