Re: [PATCH v6 00/10] OMAP: Adding Smartreflex and Voltage driver support

Tony Lindgren
2010-12-21T18:55:25Z

* Kevin Hilman <khilman@deeprootsystems.com> [101221 08:17]:
> Tony Lindgren <tony@atomide.com> writes:
>
> > * Kevin Hilman <khilman@deeprootsystems.com> [101220 17:05]:
> >> Thara Gopinath <thara@ti.com> writes:
> >>
> >> > This patch series introduces smartreflex and voltage driver support
> >> > for OMAP3430 and OMAP3630. SmartReflex modules do adaptive voltage
> >> > control for real-time voltage adjustments.
> >>
> >> Thanks Thara, these are looking good for 2.6.38.
> >>
> >> Tony, unless there are major objections, I'll be queuing these two SR
> >> series for 2.6.38. They have dependencies on Paul's integration branch
> >
> > Well looking at patch 3/6 I think it should live under drivers somewhere
> > and mostly be compiled as a module. Probably the only change needed
> > for that is to not call cpu_is_omapxxxx but instead use some flags
> > passed in the platform_data. Otherwise the whole series looks OK to me.
>
> Moving this to be a regulator driver is part of the medium-term plan,
> and is already under development. For this phase, we just split up the
> current driver into device and driver code and left under mach-omap2.
> We are investigating (and making) changes to the regulator core so that
> SmartReflex can be converted into a real regulator driver, but that is
> still under development.
>
> So, in the mean time, I'd like to merge this version so that other
> development that depends on this (the regulator work mentioned above,
> the DVFS work, etc.) can have a stable starting point.

OK up to you.

Tony