From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH] omap: rx51: Remove tvout code that plays with gpio 40 Date: Wed, 22 Dec 2010 12:00:04 +0200 Message-ID: <1293012004.6829.2.camel@tubuntu> References: <1292953561-22979-1-git-send-email-jhnikula@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.nokia.com ([147.243.128.26]:34415 "EHLO mgw-da02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214Ab0LVKAQ (ORCPT ); Wed, 22 Dec 2010 05:00:16 -0500 In-Reply-To: <1292953561-22979-1-git-send-email-jhnikula@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Jarkko Nikula Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren , Srikar On Tue, 2010-12-21 at 19:46 +0200, ext Jarkko Nikula wrote: > Commit 60d24ee "Added video data to support tvout on rx51" added code that > tries to assign gpio 40 as OMAP DSS reset_gpio for tvout. This is wrong > since this gpio has nothing to do with OMAP DSS but it is used to control > one switch that selects is the audio jack connected to tvout or audio > circuitry. > > This switch is already supported by the RX51 ASoC driver so there is no need > to control it elsewhere. Switch is contolled with ALSA control > 'Jack Function' and tvout can be selected with following example: > > amixer -D hw:0 set 'Jack Function' 'TV-OUT' Looks good. platform_enable/disable and reset_gpio fields should anyway be removed from the omap_dss_device struct, so this goes into right direction. Tony, can you take this patch also, as (I guess) it depends on the previous rx51 patches from Jarkko? Acked-by: Tomi Valkeinen Tomi