From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [RFC/PATCH 0/3] TWL4030 IRQ Changes Date: Wed, 29 Dec 2010 02:39:37 +0200 Message-ID: <1293583177.1822.4.camel@eowin> References: <20101228161657.GF2239@legolas.emea.dhcp.ti.com> <1293556459-28613-1-git-send-email-balbi@ti.com> <20101228173604.GH2239@legolas.emea.dhcp.ti.com> <20101228174138.GA3089@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101228174138.GA3089@opensource.wolfsonmicro.com> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Felipe Balbi , Linux Kernel Mailing List , Linux OMAP Mailing List , Tony Lindgren , David Brownell , Thomas Gleixner List-Id: linux-omap@vger.kernel.org Hi, On Tue, 2010-12-28 at 17:41 +0000, Mark Brown wrote: > > when we finally move to struct irq_data, the below could > > be used. BTW, Thomas do you have any plans for exposing > > irq_data_to_desc() ? > > The general idea is to move to struct irq_data sooner rather than later > (all the existing MFD drivers have already been converted). Great, I'll put this one together then. > > -static void twl4030_sih_mask(unsigned irq) > > +/* REVISIT define it here until IRQ Subsystem exports its implementation */ > > +#define irq_data_to_desc(data) container_of(data, struct irq_desc, irq_data) > > It looks like all you're using this for is to get the chip_data? If > that is the case you're looking for irq_data_get_irq_chip_data() which > will go directly from the irq_data to the chip_data. I may have missed > something, I only scanned the code. you're right, just didn't know that was such a helper. BTW, quite a big name. -- balbi