public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: sawant@ti.com
To: linux-omap@vger.kernel.org
Cc: Anand Sawant <sawant@ti.com>
Subject: [PATCH] OMAP PM: Expose vc registers in debugfs
Date: Thu, 30 Dec 2010 17:34:29 +0530	[thread overview]
Message-ID: <1293710669-3014-1-git-send-email-sawant@ti.com> (raw)

From: Anand Sawant <sawant@ti.com>

This patch will expose the following voltage controller registers
as part of voltage layer debugfs.
1. PRM_VC_BYPASS_VAL
2. PRM_VC_CMD_VAL - for all VDDs

This patch will help in debugging voltage scaling issues.

Tested on Zoom3 & OMAP4430 SDP.

Patch rebased to latest Kevin's PM branch.

Signed-off-by: Anand S Sawant <sawant@ti.com>
---
 arch/arm/mach-omap2/voltage.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
index ed6079c..a9b52e4 100644
--- a/arch/arm/mach-omap2/voltage.c
+++ b/arch/arm/mach-omap2/voltage.c
@@ -336,6 +336,11 @@ static void omap4_voltage_write_reg(u32 val, u16 mod, u8 offset)
 }
 
 /* Voltage debugfs support */
+
+/**
+ * Gets the current vp output voltage (auto-compensated) for the
+ * voltage domain.
+ */
 static int vp_volt_debug_get(void *data, u64 *val)
 {
 	struct omap_vdd_info *vdd = (struct omap_vdd_info *) data;
@@ -359,6 +364,10 @@ static int vp_volt_debug_get(void *data, u64 *val)
 	return 0;
 }
 
+/**
+ * Gets the current nominal OPP voltage (non auto-compensated) for the
+ * voltage domain.
+ */
 static int nom_volt_debug_get(void *data, u64 *val)
 {
 	struct omap_vdd_info *vdd = (struct omap_vdd_info *) data;
@@ -456,6 +465,7 @@ static void __init vp_init(struct omap_vdd_info *vdd)
 	vdd->write_reg(vp_val, mod, vdd->vp_offs.vlimitto);
 }
 
+/* Creates debugfs entries for key vp & vc parameters */
 static void __init vdd_debugfs_init(struct omap_vdd_info *vdd)
 {
 	char *name;
@@ -501,6 +511,11 @@ static void __init vdd_debugfs_init(struct omap_vdd_info *vdd)
 	(void) debugfs_create_file("curr_nominal_volt", S_IRUGO,
 				vdd->debug_dir, (void *) vdd,
 				&nom_volt_debug_fops);
+
+	(void) debugfs_create_x8("vc_bypass_val", S_IRUGO, vdd->debug_dir,
+				&(vdd->vc_reg.bypass_val_reg));
+	(void) debugfs_create_x8("vc_cmdval", S_IRUGO, vdd->debug_dir,
+				&(vdd->vc_reg.cmdval_reg));
 }
 
 /* Voltage scale and accessory APIs */
-- 
1.7.0.4


             reply	other threads:[~2010-12-30 12:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 12:04 sawant [this message]
2011-01-03 15:21 ` [PATCH] OMAP PM: Expose vc registers in debugfs Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293710669-3014-1-git-send-email-sawant@ti.com \
    --to=sawant@ti.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox