From: Felipe Balbi <me@felipebalbi.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: balbi@ti.com, "Gupta, Ajay Kumar" <ajay.gupta@ti.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support
Date: Tue, 04 Jan 2011 16:06:24 +0200 [thread overview]
Message-ID: <1294149984.1822.9.camel@eowin> (raw)
In-Reply-To: <4D231B5F.7030607@mvista.com>
Hi,
(using personal email, left the office)
On Tue, 2011-01-04 at 16:06 +0300, Sergei Shtylyov wrote:
> >> I think we will get more clarity once we start on this activity.
>
> > I agree, but I personally don't see that many limiting factors.
> > dmaengine is just a generic API for doing DMA transfers. If it's not
> > enough for us currently, we extend it.
>
> Putting MUSB DMA enignes into drivers/dma/ is the same as taking *any*
> chip capable of bus-mastering DMA, "separating" its bus mastering related code
> from its driver and putting this code into drivers/dma/. This doesn't make
> sense, in my opinion. drivers/dma/ is for the dedicated DMA controllers (which
> can *optionally* serve the slave devices).
Do I really have to spell it out ? Really ?
You don't need to physically move the part of the code to drivers/dma,
but it has to use the API. The mentor DMA is internal to MUSB.
tusb6010_omap.c isn't.
Where it makes sense to move the code under drivers/dma, it will be
done, where it doesn't, it won't be done, but it will use the same API.
That's all.
The end goal is just to drop all these ad-hoc "APIs" for accessing DMA
on musb code.
--
balbi
next prev parent reply other threads:[~2011-01-04 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201005152214.53993.sshtylyov@ru.mvista.com>
[not found] ` <4D21F3F2.6090302@mvista.com>
2011-01-03 16:34 ` [PATCH v5 1/3] ARM: add CPPI 4.1 DMA support Russell King - ARM Linux
2011-01-03 17:01 ` Gupta, Ajay Kumar
2011-01-03 17:07 ` Sergei Shtylyov
[not found] ` <4D220246.5020303-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2011-01-03 17:15 ` Gupta, Ajay Kumar
2011-01-03 20:44 ` Felipe Balbi
2011-01-04 13:06 ` Sergei Shtylyov
2011-01-04 14:06 ` Felipe Balbi [this message]
2011-01-04 14:40 ` Ming Lei
2011-01-04 14:56 ` Felipe Balbi
2011-01-04 15:41 ` Ming Lei
2011-01-04 18:42 ` Felipe Balbi
2011-01-04 18:50 ` Sergei Shtylyov
2011-01-04 16:37 ` Sergei Shtylyov
2011-01-05 22:03 ` Russell King - ARM Linux
2011-01-03 17:19 ` Russell King - ARM Linux
2011-01-03 20:49 ` Felipe Balbi
2011-01-04 19:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294149984.1822.9.camel@eowin \
--to=me@felipebalbi.com \
--cc=ajay.gupta@ti.com \
--cc=balbi@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox