From: Nishanth Menon <nm@ti.com>
To: l-o <linux-omap@vger.kernel.org>
Cc: l-a <linux-arm-kernel@lists.infradead.org>,
Kevin <khilman@ti.com>, Tony <tony@atomide.com>,
Koen Kooi <koen@beagleboard.org>, Aaro <aaro.koskinen@nokia.com>,
Nishanth Menon <nm@ti.com>
Subject: [PATCH v5 1/3] omap3: beaglexm: fix EHCI power up GPIO dir
Date: Tue, 11 Jan 2011 11:13:35 -0600 [thread overview]
Message-ID: <1294766017-12182-2-git-send-email-nm@ti.com> (raw)
In-Reply-To: <[PATCH v4 0/3] OMAP3: beaglexm: GPIO fixes>
From: Koen Kooi <koen@beagleboard.org>
EHCI enable power pin is inverted (active high) in comparison
to vanilla beagle which is active low. Handle this case conditionally.
Without this fix, Beagle XM 4 port EHCI will not function and no
networking will be available
[nm@ti.com: split up, added descriptive changelogs]
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Koen Kooi <koen@beagleboard.org>
---
arch/arm/mach-omap2/board-omap3beagle.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 6c12760..af1166b 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -297,9 +297,15 @@ static int beagle_twl_gpio_setup(struct device *dev,
gpio_request(gpio + 1, "EHCI_nOC");
gpio_direction_input(gpio + 1);
- /* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
+ /*
+ * TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, XM active
+ * high / others active low)
+ */
gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
- gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
+ if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
+ gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
+ else
+ gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
--
1.6.3.3
next prev parent reply other threads:[~2011-01-11 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH v4 0/3] OMAP3: beaglexm: GPIO fixes>
2011-01-11 17:13 ` [PATCH v5 0/3] OMAP3: beaglexm: GPIO fixes Nishanth Menon
2011-01-11 17:13 ` Nishanth Menon [this message]
2011-01-11 17:13 ` [PATCH v5 2/3] omap3: beaglexm: fix DVI reset GPIO Nishanth Menon
2011-01-11 17:13 ` [PATCH v5 3/3] omap3: beaglexm: fix power on of DVI Nishanth Menon
2011-01-11 23:23 ` Tony Lindgren
2011-01-11 23:55 ` Nishanth Menon
2011-01-12 0:15 ` Tony Lindgren
2011-01-12 0:17 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294766017-12182-2-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=aaro.koskinen@nokia.com \
--cc=khilman@ti.com \
--cc=koen@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox