From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Ben Tucker <btucker@mpcdata.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: OMAP DSS Enable clocks in dss_setup_partial_planes
Date: Wed, 12 Jan 2011 11:14:18 +0200 [thread overview]
Message-ID: <1294823658.4156.18.camel@tubuntu> (raw)
In-Reply-To: <c08bf1989fbe2e704960116748c416f3@mail.gmail.com>
Hi,
On Tue, 2011-01-11 at 17:41 +0000, ext Ben Tucker wrote:
> From 086e3454c8f154cd90a4669899f2179f16ef32cd Mon Sep 17 00:00:00 2001
> From: Ben Tucker <btucker@mpc-data.co.uk>
> Date: Thu, 13 Jan 2011 12:56:45 +0000
> Subject: [PATCH] OMAP DSS Enable clocks in dss_setup_partial_planes
> Enable the interface clocks while calling
> configure_dispc().
This description doesn't really tell anything which isn't selfevident
from the code below. Please check
http://who-t.blogspot.com/2009/12/on-commit-messages.html
But I presume this is about RFBI. If so, correct place to enable the
clocks would be in rfbi.c.
Tomi
> ---
> drivers/video/omap2/dss/manager.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/manager.c
> b/drivers/video/omap2/dss/manager.c
> index 545e9b9..cb90dac 100644
> --- a/drivers/video/omap2/dss/manager.c
> +++ b/drivers/video/omap2/dss/manager.c
> @@ -1106,7 +1106,9 @@ void dss_setup_partial_planes(struct omap_dss_device
> *dssdev,
> mc->w = w;
> mc->h = h;
>
> + dss_clk_enable(DSS_CLK_ICK | DSS_CLK_FCK1);
> configure_dispc();
> + dss_clk_disable(DSS_CLK_ICK | DSS_CLK_FCK1);
>
> mc->do_manual_update = false;
>
> --
> 1.7.3.2
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-12 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 14:18 RFBI worked example Ben Tucker
2011-01-07 15:13 ` Tomi Valkeinen
2011-01-07 17:25 ` Ben Tucker
2011-01-11 17:41 ` OMAP DSS Enable clocks in dss_setup_partial_planes Ben Tucker
2011-01-12 9:14 ` Tomi Valkeinen [this message]
2011-01-12 11:20 ` Ben Tucker
2011-01-12 13:10 ` Tomi Valkeinen
2011-01-20 9:58 ` Taneja, Archit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294823658.4156.18.camel@tubuntu \
--to=tomi.valkeinen@nokia.com \
--cc=btucker@mpcdata.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox