From: Tomi Valkeinen <tomi.valkeinen@nokia.com>
To: ext Ben Tucker <btucker@mpcdata.com>
Cc: linux-omap@vger.kernel.org
Subject: RE: OMAP DSS Enable clocks in dss_setup_partial_planes
Date: Wed, 12 Jan 2011 15:10:56 +0200 [thread overview]
Message-ID: <1294837856.15030.33.camel@tubuntu> (raw)
In-Reply-To: <93718b46f4f9309fb4b87599040a432f@mail.gmail.com>
On Wed, 2011-01-12 at 11:20 +0000, ext Ben Tucker wrote:
> > -----Original Message-----
> > From: Tomi Valkeinen [mailto:tomi.valkeinen@nokia.com]
> > Sent: 12 January 2011 09:14
> > To: ext Ben Tucker
> > Cc: linux-omap@vger.kernel.org
> > Subject: Re: OMAP DSS Enable clocks in dss_setup_partial_planes
> >
> > Hi,
> >
> > On Tue, 2011-01-11 at 17:41 +0000, ext Ben Tucker wrote:
> > > From 086e3454c8f154cd90a4669899f2179f16ef32cd Mon Sep 17 00:00:00
> > 2001
> > > From: Ben Tucker <btucker@mpc-data.co.uk>
> > > Date: Thu, 13 Jan 2011 12:56:45 +0000
> > > Subject: [PATCH] OMAP DSS Enable clocks in dss_setup_partial_planes
> > > Enable the interface clocks while calling>
> > > > configure_dispc().
> >
> > This description doesn't really tell anything which isn't selfevident
> > from the code below. Please check
> > http://who-t.blogspot.com/2009/12/on-commit-messages.html
> >
> > But I presume this is about RFBI. If so, correct place to enable the
> > clocks would be in rfbi.c.
> >
> > Tomi
> >
>
> Apologies for the commit message. Updated patch below.
>
> Are you sure the code to enable clocks should be placed in rfbi.c? The DSI
> code (dsi.c) uses dss_setup_partial_planes() in the same way as rfbi.c and
> there is no clock enable code there. Also omap_dss_mgr_apply() within
> manager.c enables clocks for the configure_dispc() call.
Usually the user should enable the clocks, in this case rfbi.c. DSI
handles this so that the clocks are always enabled when the display is
enabled. This could be easier for RFBI also, but due to legacy reasons
RFBI currently tries to keep clocks disabled except when its actually
doing something.
As for omap_dss_mgr_apply(), that function is also a "user" in this
case. Apply is called from outside DSS driver, usually from omapfb.
If the clk_enable/disable calls would be in the lower levels, this would
mean a) greater overhead from clk_enable/disable calls and b) context
saves and restores, as the DSS HW could go into OFF mode when the clocks
are disabled.
Tomi
next prev parent reply other threads:[~2011-01-12 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 14:18 RFBI worked example Ben Tucker
2011-01-07 15:13 ` Tomi Valkeinen
2011-01-07 17:25 ` Ben Tucker
2011-01-11 17:41 ` OMAP DSS Enable clocks in dss_setup_partial_planes Ben Tucker
2011-01-12 9:14 ` Tomi Valkeinen
2011-01-12 11:20 ` Ben Tucker
2011-01-12 13:10 ` Tomi Valkeinen [this message]
2011-01-20 9:58 ` Taneja, Archit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294837856.15030.33.camel@tubuntu \
--to=tomi.valkeinen@nokia.com \
--cc=btucker@mpcdata.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox