From: Daniel Morsing <daniel.morsing@gmail.com>
To: Thomas Weber <weber@corscience.de>
Cc: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 0/3] omap3: devkit8000: misc fixes
Date: Fri, 14 Jan 2011 10:44:46 +0100 [thread overview]
Message-ID: <1294998286.3458.13.camel@morsing> (raw)
In-Reply-To: <4D300DC8.7000803@corscience.de>
On Fri, 2011-01-14 at 09:48 +0100, Thomas Weber wrote:
> Hello Daniel,
>
> the LCD_PWREN is connected to TWL4030 LEDA only.
> The TWL4030 GPIO.1 has a not connected resistor (R61).
>
> My test case is:
>
> # echo 0 > /sys/devices/omapdss/display0/enabled
> # echo 1 > /sys/devices/omapdss/display0/enabled
>
>
> I changed your patch the following way.
I just checked and you are correct. This would also mean that the
pullup/pulldown patch is incorrect since gpio.1 is now not connected and
should be pulled down.
> I think I cannot write a sign-off-by for you.
Fine by me.
> Author: Daniel Morsing <daniel.morsing@gmail.com>
I don't think i can rightfully call myself the author of this patch
anymore :)
Regards,
Daniel
prev parent reply other threads:[~2011-01-14 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 0:03 [PATCH 0/3] omap3: devkit8000: misc fixes Daniel Morsing
2011-01-14 0:03 ` [PATCH 1/3] omap3: devkit8000: Fix indentation issue Daniel Morsing
2011-01-14 0:03 ` [PATCH 2/3] omap3: devkit8000: fix tps65930 pullup/pulldown configuration Daniel Morsing
2011-01-14 11:49 ` Daniel Morsing
2011-01-14 0:03 ` [PATCH 3/3] omap3: devkit8000: Use generic gpio for second lcd enable Daniel Morsing
2011-01-14 8:48 ` [PATCH 0/3] omap3: devkit8000: misc fixes Thomas Weber
2011-01-14 9:44 ` Daniel Morsing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294998286.3458.13.camel@morsing \
--to=daniel.morsing@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox