Re: [PATCH v2 0/2] OMAP: omap_device: API to modify SYSCONFIG register

ABRAHAM, KISHON VIJAY
2011-02-24T09:23:36Z

Hi Kevin, Paul, Benoit,

Do you have any comments for this patch series? This series is
necessary for McBSP hwmod and
PM runtime patch series to be merged.

Regards
Kishon

On Tue, Feb 15, 2011 at 12:08 PM, ABRAHAM, KISHON VIJAY <kishon@ti.com> wrote:
> Kevin, Paul, Benoit,
>
> Do you have any comments for this patch series?
>
> -Kishon
>
> On Mon, Jan 31, 2011 at 6:04 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> Certain peripherals require autoidle bits to be disabled before performing
>> some operations. This patch series provides APIs in omap_device layer to
>> modify the SYSCONFIG register.
>>
>> Since current implementation of PM run time framework does not support
>> changing sysconfig settings during middle of the on going operation,
>> these APIs will support the same.
>>
>> For e.g McBSP 2 and 3 in OMAP3 has sidetone feature which requires
>> autoidle to be disabled before starting the sidetone.
>>
>> McBSP also requires the SYSCONFIG to be in NOIDLE when ELEMENTSYNCH
>> mode is selected for DMA operation.
>>
>> Created on top of linux OMAP master (linux-omap-2.6 :master)
>> Tested on OMAP4430, OMAP3430 and OMAP2430 SDP boards. Verified that this patch
>> series does not break the OMAP1 build.
>>
>> V2:
>> Mutex is replaced with spinlock.
>>
>> V1:
>> * Creates 3 separate API's to change the idle mode to NOIDLE, SMARTIDLE
>>  and FORCEIDLE and one more API to change the idlemode to default value
>>  based on the hwmod flag. This change is done to align with the discussion
>>  on [3]
>>
>> * Added hwmod mutex in omap hwmod APIs that modifies SYSCONFIG register.
>>
>> * omap_hwmod_set_slave_idlemode() is not modified to take true/false kind-of
>> argument since 3 states are associated with SIDLE bits (force, no and smart).
>>
>> These changes were made to align with Benoit's and Paul's comments for a
>> similar patch written by Manjunath [1] for changing MSTANDBY bits.
>>
>> The discussions that happened for the RFC patch can be found at [2]
>>
>> [1]: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg39647.html
>> [2]: https://patchwork.kernel.org/patch/134371/
>> [3]: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg39615.html
>>
>> Kishon Vijay Abraham I (2):
>>  OMAP: hwmod: API to handle autoidle mode
>>  OMAP: omap_device: API to modify AUTOIDLE and SMARTIDLE bits
>>
>>  arch/arm/mach-omap2/omap_hwmod.c              |   36 +++++
>>  arch/arm/plat-omap/include/plat/omap_device.h |    6 +
>>  arch/arm/plat-omap/include/plat/omap_hwmod.h  |    1 +
>>  arch/arm/plat-omap/omap_device.c              |  176 +++++++++++++++++++++++++
>>  4 files changed, 219 insertions(+), 0 deletions(-)
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html