From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>
Subject: [PATCH 01/15] cbus: retu: drop retu_get_status
Date: Tue, 15 Feb 2011 10:45:48 +0200 [thread overview]
Message-ID: <1297759562-25682-2-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1297759562-25682-1-git-send-email-balbi@ti.com>
children are allocated after retu core probes,
so by the time children start to probe, parent
is initialized for sure.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/cbus/retu-rtc.c | 6 ------
drivers/cbus/retu-wdt.c | 8 --------
drivers/cbus/retu.c | 6 ------
drivers/cbus/retu.h | 1 -
4 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/drivers/cbus/retu-rtc.c b/drivers/cbus/retu-rtc.c
index 5f52edf..303a4a6 100644
--- a/drivers/cbus/retu-rtc.c
+++ b/drivers/cbus/retu-rtc.c
@@ -215,12 +215,6 @@ static int __init retu_rtc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, rtc);
mutex_init(&rtc->mutex);
- r = retu_get_status();
- if (!r) {
- dev_err(&pdev->dev, "retu not initialized\n");
- goto err1;
- }
-
rtc->alarm_expired = retu_read_reg(RETU_REG_IDR) &
(0x1 << RETU_INT_RTCA);
diff --git a/drivers/cbus/retu-wdt.c b/drivers/cbus/retu-wdt.c
index 8b87ae9..423216c 100644
--- a/drivers/cbus/retu-wdt.c
+++ b/drivers/cbus/retu-wdt.c
@@ -230,10 +230,6 @@ static int __devinit retu_wdt_ping(void)
{
int r;
- r = retu_get_status();
- if (!r)
- return -ENODEV;
-
#ifdef CONFIG_WATCHDOG_NOWAYOUT
retu_modify_counter(RETU_WDT_MAX_TIMER);
#else
@@ -258,10 +254,6 @@ static int __init retu_wdt_probe(struct platform_device *pdev)
struct retu_wdt_dev *wdev;
int ret;
- ret = retu_get_status();
- if (!ret)
- return -ENODEV;
-
wdev = kzalloc(sizeof(struct retu_wdt_dev), GFP_KERNEL);
if (!wdev)
return -ENOMEM;
diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c
index 6134781..5886b00 100644
--- a/drivers/cbus/retu.c
+++ b/drivers/cbus/retu.c
@@ -74,12 +74,6 @@ struct retu {
static struct retu *the_retu;
-int retu_get_status(void)
-{
- return the_retu ? 1 : 0;
-}
-EXPORT_SYMBOL(retu_get_status);
-
/**
* retu_read_reg - Read a value from a register in Retu
* @reg: the register to read from
diff --git a/drivers/cbus/retu.h b/drivers/cbus/retu.h
index 1b05f3e..f2357a9 100644
--- a/drivers/cbus/retu.h
+++ b/drivers/cbus/retu.h
@@ -57,7 +57,6 @@
#define MAX_RETU_IRQ_HANDLERS 16
-int retu_get_status(void);
int retu_read_reg(unsigned reg);
void retu_write_reg(unsigned reg, u16 val);
void retu_set_clear_reg_bits(unsigned reg, u16 set, u16 clear);
--
1.7.4.rc2
next prev parent reply other threads:[~2011-02-15 8:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 8:45 [PATCH 00/15] More cleanups Felipe Balbi
2011-02-15 8:45 ` Felipe Balbi [this message]
2011-02-15 8:45 ` [PATCH 02/15] cbus: retu: replace BUG_ON with WARN Felipe Balbi
2011-02-15 8:45 ` [PATCH 03/15] cbus: retu: drop the unnecessary spinlock_t Felipe Balbi
2011-02-15 8:45 ` [PATCH 04/15] cbus: retu: drop unused PFX macro Felipe Balbi
2011-02-15 8:45 ` [PATCH 05/15] arm: omap: cbus: add IDs for Retu and Tahvo Felipe Balbi
2011-02-15 8:45 ` [PATCH 06/15] arm: omap: pass Retu ID via platform_data Felipe Balbi
2011-02-15 8:45 ` [PATCH 07/15] cbus: retu: use the devid from platform_data Felipe Balbi
2011-02-15 8:45 ` [PATCH 08/15] cbus: retu: introduce internal read/write functions Felipe Balbi
2011-02-15 8:45 ` [PATCH 09/15] cbus: retu: search and replace Felipe Balbi
2011-02-15 8:45 ` [PATCH 10/15] cbus: retu: pwrbutton: save device pointer on our structure Felipe Balbi
2011-02-16 18:07 ` [PATCH 00/15] More cleanups Tony Lindgren
2011-02-16 19:18 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297759562-25682-2-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox