Re: [PATCH 0/6] trivial compile warning fixes

Felipe Balbi
2011-02-16T19:48:48Z

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

On Wed, Feb 16, 2011 at 09:30:33AM -0800, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [110215 04:47]:
> > Hi Tony,
> >
> > following are a few compile warning fixes for your
> > consideration.
>
> I already got youre previous set queued in devel-cleanup
> branch. Care to see if that needs further patching?

attached patch is needed.

--
balbi

[-- Attachment #2: 0001-arm-omap2-clksel-fix-compile-warning.diff --]
[-- Type: text/x-diff, Size: 1145 bytes --]

>From b1487889dc0e6d3c328d658e5d6730373785a49c Mon Sep 17 00:00:00 2001
From: Felipe Balbi <balbi@ti.com>
Date: Sun, 16 Jan 2011 13:22:03 +0200
Subject: [PATCH] arm: omap2: clksel: fix compile warning
Organization: Texas Instruments\n

Fix the following compile warning:
arch/arm/mach-omap2/clkt_clksel.c: In function '_get_div_and_fieldval':
arch/arm/mach-omap2/clkt_clksel.c:100:35: warning: 'max_clkr' may be
used uninitialized in this function

Acked-by: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/mach-omap2/clkt_clksel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/clkt_clksel.c b/arch/arm/mach-omap2/clkt_clksel.c
index a781cd6..e25364d 100644
--- a/arch/arm/mach-omap2/clkt_clksel.c
+++ b/arch/arm/mach-omap2/clkt_clksel.c
@@ -97,7 +97,7 @@ static u8 _get_div_and_fieldval(struct clk *src_clk, struct clk *clk,
u32 *field_val)
{
const struct clksel *clks;
- const struct clksel_rate *clkr, *max_clkr;
+ const struct clksel_rate *clkr, *max_clkr = NULL;
u8 max_div = 0;

clks = _get_clksel_by_parent(clk, src_clk);
--
1.7.4.rc2