From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
kernel-team@lists.ubuntu.com
Subject: Re: omap3: Adding vdd_sdi regulator supply to OMAP3EVM
Date: Mon, 21 Feb 2011 11:08:15 +0200 [thread overview]
Message-ID: <1298279295.4931.31.camel@deskari> (raw)
In-Reply-To: <1297930274-16278-1-git-send-email-bryan.wu@canonical.com>
Hi,
On Thu, 2011-02-17 at 08:11 +0000, Bryan Wu wrote:
> From: Mathieu J. Poirier <mathieu.poirier@canonical.com>
>
> https://bugs.launchpad.net/bugs/630885
>
> When booting, the omapdss subsystem is looking for a regulator named
> "vdds_sdi". When the regulator is not found the initialisation sequence
> is aborted resulting in omapfb not finding a display to work with. This
> patch allows the omapfb sub system to complete its initialisation
> properly and enable LCD display. The problem was fixed by lumping a
> "vdds_sdi" with the already existing "vdds_dsi" regulator. This fix
> takes its root from work done on the Beagle board and the Pandora board.
This isn't a correct fix.
If we would add the sdi regulator to remove the problem we would need to
add the sdi regulator to all boards, not just EVM.
However, I wouldn't go adding them. The proper fix is to make sdi.c only
use the regulator if SDI is actually used. Currently it tries to acquire
it always.
A simple "fix" for this is to disable SDI from Kconfig, presuming you
don't have boards that use SDI interface. N900 is the only board that I
know of which uses SDI.
Tomi
prev parent reply other threads:[~2011-02-21 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 8:11 [PATCH] omap3: Adding vdd_sdi regulator supply to OMAP3EVM Bryan Wu
2011-02-21 7:02 ` Bryan Wu
2011-02-21 8:24 ` archit taneja
2011-02-21 9:08 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298279295.4931.31.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=bryan.wu@canonical.com \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox