Re: OMAP2,3: DSS2: Report -EBUSY when to many registered isr

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

Hi,

On Fri, 2011-01-21 at 04:53 +0000, Ben Tucker wrote:
> From: Ben Tucker <btucker@mpc-data.co.uk>
> 
> This patch fixes a problem with map_dispc_register_isr() where it
> fails to return -EBUSY if it has no more space for registrations.

Looks correct, but a couple of things:
- Missing signed-off
- Indentation is wrong
- Don't use { } when there's just one line in the if block

Please fix those, or alternatively I can fix the bug myself and add you
as reported-by.

 Tomi


> 
> ---
> drivers/video/omap2/dss/dispc.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
> index e0e8275..f566177 100644
> --- a/drivers/video/omap2/dss/dispc.c
> +++ b/drivers/video/omap2/dss/dispc.c
> @@ -2579,6 +2579,10 @@ int omap_dispc_register_isr(omap_dispc_isr_t isr, void *arg, u32 mask)
>  		break;
>  	}
>  
> +    if (ret) {
> +        goto err;
> +    }
> +
>  	_omap_dispc_set_irqs();
>  
>  	spin_unlock_irqrestore(&dispc.irq_lock, flags);