Re: [Patch 1/2] OMAP2PLUS: DSS2: Add dss_opt_clk_roles in pdata

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Mon, 2011-02-28 at 03:17 -0600, Semwal, Sumit wrote:
> Hi Tomi,
> 
> On Mon, Feb 28, 2011 at 2:40 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:

<snip>

> > And is there even need to create clk_roles array. If I'm not mistaken,
> > the only use for this data is for the opt_clock_available() function. We
> > could just have an opt_clock_available() function pointer in the
> > omap_display_platform_data, and the function itself would be in
> > display.c. And the function could use the original hwmod data.
> Ok, but in that case, we do the same hwmod lookup everytime, is it?

Yes. I have no idea if hwmod lookup is heavy or not. But:

> That may not be so bad though, considering we check that very rarely
> [in dsshw_probe=>dss_get_clocks() path].

Yep, we do it once (if we're not unloading & loading modules). So I
don't think it matters. But if you want, you could do
omap_hwmod_lookup("dss_core") in omap_display_init(), and store the
return value somewhere.

 Tomi