From: "Michael Büsch" <mb@bu3sch.de>
To: balbi@ti.com
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] cbus-retu: Acquire mutex on write operation
Date: Mon, 28 Feb 2011 15:10:02 +0100 [thread overview]
Message-ID: <1298902202.26482.3.camel@maggie> (raw)
In-Reply-To: <20110228083317.GH2459@legolas.emea.dhcp.ti.com> (sfid-20110228_093326_715657_FFFFFFFFA688BA7F)
On Mon, 2011-02-28 at 10:33 +0200, Felipe Balbi wrote:
> On Sun, Feb 27, 2011 at 12:34:33AM +0100, Michael Buesch wrote:
> > The mutex has to be acquired on register write to avoid interference
> > with a simultaneous retu_set_clear_reg_bits operation.
> >
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> good catch, please do the same for retu_read_reg()
I don't think this is necessary, because cbus_read_reg() and
cbus_write_reg() are atomic due to the cbus host->lock.
I think we can depend on this.
We could probably improve the comment on the lock in
cbus_transfer(), though.
--
Greetings Michael.
prev parent reply other threads:[~2011-02-28 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 23:34 [PATCH] cbus-retu: Acquire mutex on write operation Michael Buesch
2011-02-28 8:33 ` Felipe Balbi
2011-02-28 14:10 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298902202.26482.3.camel@maggie \
--to=mb@bu3sch.de \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox