From: "Michael Büsch" <mb@bu3sch.de>
To: balbi@ti.com
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] cbus-retu: Fix nested IRQ handling
Date: Mon, 28 Feb 2011 15:16:14 +0100 [thread overview]
Message-ID: <1298902574.26482.8.camel@maggie> (raw)
In-Reply-To: <20110228083629.GI2459@legolas.emea.dhcp.ti.com> (sfid-20110228_093639_404968_FFFFFFFFE1932FBC)
On Mon, 2011-02-28 at 10:36 +0200, Felipe Balbi wrote:
> On Sun, Feb 27, 2011 at 06:17:01PM +0100, Michael Buesch wrote:
> > handle_nested_irq() expects a global IRQ number, so
> > the irq_base has to be added to the RETU irq number.
> >
> > Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> Good catch, while at that, could you also cook another patch to add
> locking on retu_irq_handler ? We are using the internal lockless
> version of the read/write functions, so we need to hold the mutex before
> reading/writing to avoid problems.
Ok, it probably is safe without locking (due to the reads being atomic),
but I agree that it's more robust to add some locking here. I'll send
a patch.
--
Greetings Michael.
prev parent reply other threads:[~2011-02-28 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 17:17 [PATCH] cbus-retu: Fix nested IRQ handling Michael Buesch
2011-02-28 8:36 ` Felipe Balbi
2011-02-28 14:16 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298902574.26482.8.camel@maggie \
--to=mb@bu3sch.de \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox