From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 3/8] OMAP4 : DSS2 : HDMI: HDMI driver header file addition
Date: Tue, 1 Mar 2011 19:23:26 +0200 [thread overview]
Message-ID: <1299000206.2049.43.camel@deskari> (raw)
In-Reply-To: <1298988988-28429-4-git-send-email-mythripk@ti.com>
On Tue, 2011-03-01 at 08:16 -0600, K, Mythri P wrote:
> Adding the hdmi interface driver header file (hdmi.h) to the dss driver.
> Register and timing declaration to be used by the corresponding c file
> is added in this file.
>
> Signed-off-by: Mythri P K <mythripk@ti.com>
> ---
> drivers/video/omap2/dss/hdmi.h | 597 ++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 597 insertions(+), 0 deletions(-)
> create mode 100644 drivers/video/omap2/dss/hdmi.h
This file is dss internal header. How will the audio side be handled?
Does the audio driver need something from here? If so, those things
should be somewhere else.
Some or many of the structs/enums in this file are not used currently.
It would make reviewing and understanding the code much easier, if
things would be added only when they are actually used. Can you go
through them and leave only the things that are needed for the current
driver.
Tomi
next prev parent reply other threads:[~2011-03-01 17:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 14:16 [PATCH v2 0/8] OMAP4 : DSS2 : HDMI support Mythri P K
2011-03-01 14:16 ` [PATCH v2 1/8] OMAP4 : DSS2 : Add display type HDMI to DSS2 Mythri P K
2011-03-01 14:16 ` [PATCH v2 2/8] OMAP4 : DSS2 : HDMI: HDMI specific display controller and dss change Mythri P K
2011-03-01 17:01 ` Tomi Valkeinen
2011-03-03 4:27 ` K, Mythri P
2011-03-03 5:29 ` K, Mythri P
2011-03-03 6:40 ` Tomi Valkeinen
2011-03-01 14:16 ` [PATCH v2 3/8] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Mythri P K
2011-03-01 17:23 ` Tomi Valkeinen [this message]
2011-03-01 14:16 ` [PATCH v2 4/8] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS drivers interface Mythri P K
2011-03-01 17:37 ` Tomi Valkeinen
2011-03-03 4:35 ` K, Mythri P
2011-03-01 14:16 ` [PATCH v2 5/8] OMAP4 : DSS2 : HDMI: HDMI panel driver addition in the DSS Mythri P K
2011-03-01 17:11 ` Tomi Valkeinen
2011-03-03 4:28 ` K, Mythri P
2011-03-01 14:16 ` [PATCH v2 6/8] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Mythri P K
2011-03-01 14:16 ` [PATCH v2 7/8] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 SDP Mythri P K
2011-03-01 14:16 ` [PATCH v2 8/8] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 PANDA Mythri P K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299000206.2049.43.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox