From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] omapfb: Fix linker error in drivers/video/omap/lcd_2430sdp.c
Date: Wed, 2 Mar 2011 09:58:49 +0200 [thread overview]
Message-ID: <1299052729.2226.44.camel@deskari> (raw)
In-Reply-To: <1298968837-13584-1-git-send-email-jhnikula@gmail.com>
On Tue, 2011-03-01 at 02:40 -0600, Jarkko Nikula wrote:
> There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
> set. This can be triggered on OMAP2 builds when OMAP3 or OMAP4 are not set.
>
> drivers/built-in.o: In function `sdp2430_panel_disable':
> drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
> drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
> drivers/built-in.o: In function `sdp2430_panel_enable':
> drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
> drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'
>
> Fix this by selecting the TWL4030_CORE for MACH_OMAP_2430SDP when building
> with CONFIG_FB_OMAP as there is no own Kconfig entry for lcd_2430 and it is
> compiled always when both MACH_OMAP_2430SDP and FB_OMAP are set.
Thanks, applied.
Tomi
prev parent reply other threads:[~2011-03-02 7:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 9:17 [PATCH] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c Jarkko Nikula
2011-02-20 20:04 ` [PATCH resend] " Jarkko Nikula
2011-02-24 21:26 ` Tony Lindgren
2011-02-28 14:47 ` Jarkko Nikula
2011-02-28 15:09 ` Tomi Valkeinen
2011-03-01 1:39 ` Tony Lindgren
2011-03-01 6:29 ` Tomi Valkeinen
2011-03-02 17:36 ` Tony Lindgren
2011-03-01 8:40 ` [PATCH] omapfb: " Jarkko Nikula
2011-03-02 7:58 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299052729.2226.44.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=jhnikula@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox