Re: [PATCH v2 2/8] OMAP4 : DSS2 : HDMI: HDMI specific display controller and dss change.

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

Hi,

On Wed, 2011-03-02 at 23:29 -0600, K, Mythri P wrote:
> Hi Tomi,
> I just rechecked the TRM.
> The TRM description of the bit is VENC_HDMI_switch , Wouldnt it be
> appropriate to have the same
> name for the enum and the variables as suggested by you.

Please don't top-post when posting to mailing lists.

Yes, it's a good rule of thumb to have similar naming with the TRM.
However, we shouldn't follow TRM blindly, and also TRM can be changed.

In this case we already have a bunch of functions to configure the clock
muxes, like
void dss_select_dispc_clk_source(enum dss_clk_source clk_src)

Also, a function name like dss_select_hdmi_venc doesn't really tell
anything about what it does. Even if you know the architecture of DSS
HW, you can't deduce what the function does.

And usually when you are pondering about the clocking configuration, you
look at the DSS clock tree figure (fig 10-4), or the DSS clock sources
table 10-3. And in this case I believe the naming in those figures and
tables are much better than the name of the bit we are setting.

 Tomi