From: David Cohen <dacohen@gmail.com>
To: Hiroshi.DOYU@nokia.com
Cc: linux-omap@vger.kernel.org, fernando.lugo@ti.com,
linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
sakari.ailus@maxwell.research.nokia.com,
Michael Jones <michael.jones@matrix-vision.de>
Subject: [PATCH 1/3] omap: iovmm: disallow mapping NULL address
Date: Tue, 8 Mar 2011 14:46:03 +0200 [thread overview]
Message-ID: <1299588365-2749-2-git-send-email-dacohen@gmail.com> (raw)
In-Reply-To: <1299588365-2749-1-git-send-email-dacohen@gmail.com>
From: Michael Jones <michael.jones@matrix-vision.de>
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address if da_start==0, which would then not get unmapped.
Disallow this again. And spell variable 'alignment' correctly.
Signed-off-by: Michael Jones <michael.jones@matrix-vision.de>
---
arch/arm/plat-omap/iovmm.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 6dc1296..11c9b76 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -271,20 +271,24 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
size_t bytes, u32 flags)
{
struct iovm_struct *new, *tmp;
- u32 start, prev_end, alignement;
+ u32 start, prev_end, alignment;
if (!obj || !bytes)
return ERR_PTR(-EINVAL);
start = da;
- alignement = PAGE_SIZE;
+ alignment = PAGE_SIZE;
if (flags & IOVMF_DA_ANON) {
- start = obj->da_start;
+ /* Don't map address 0 */
+ if (obj->da_start)
+ start = obj->da_start;
+ else
+ start = obj->da_start + alignment;
if (flags & IOVMF_LINEAR)
- alignement = iopgsz_max(bytes);
- start = roundup(start, alignement);
+ alignment = iopgsz_max(bytes);
+ start = roundup(start, alignment);
} else if (start < obj->da_start || start > obj->da_end ||
obj->da_end - start < bytes) {
return ERR_PTR(-EINVAL);
@@ -304,7 +308,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
goto found;
if (tmp->da_end >= start && flags & IOVMF_DA_ANON)
- start = roundup(tmp->da_end + 1, alignement);
+ start = roundup(tmp->da_end + 1, alignment);
prev_end = tmp->da_end;
}
--
1.7.0.4
next prev parent reply other threads:[~2011-03-08 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 12:46 [PATCH 0/3] omap: iovmm: Fix IOVMM check for fixed 'da' David Cohen
2011-03-08 12:46 ` David Cohen [this message]
2011-03-08 18:06 ` [PATCH 1/3] omap: iovmm: disallow mapping NULL address Guzman Lugo, Fernando
2011-03-08 19:06 ` David Cohen
2011-03-08 19:53 ` Guzman Lugo, Fernando
2011-03-08 20:07 ` David Cohen
2011-03-08 12:46 ` [PATCH 2/3] omap3: change ISP's IOMMU da_start address David Cohen
2011-03-08 14:06 ` Sakari Ailus
2011-03-08 17:15 ` David Cohen
2011-03-08 12:46 ` [PATCH 3/3] omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED/IOVMF_DA_ANON flags David Cohen
2011-03-08 17:59 ` Guzman Lugo, Fernando
2011-03-08 18:09 ` Hiroshi DOYU
2011-03-08 18:53 ` Guzman Lugo, Fernando
2011-03-08 18:57 ` David Cohen
2011-03-08 19:33 ` Guzman Lugo, Fernando
2011-03-08 19:46 ` David Cohen
2011-03-08 19:51 ` David Cohen
2011-03-08 12:49 ` [PATCH 0/3] omap: iovmm: Fix IOVMM check for fixed 'da' Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299588365-2749-2-git-send-email-dacohen@gmail.com \
--to=dacohen@gmail.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=fernando.lugo@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael.jones@matrix-vision.de \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).