From: David Cohen <dacohen@gmail.com>
To: Hiroshi.DOYU@nokia.com
Cc: linux-omap@vger.kernel.org, fernando.lugo@ti.com,
linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
sakari.ailus@maxwell.research.nokia.com,
David Cohen <dacohen@gmail.com>
Subject: [PATCH 3/3] omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED/IOVMF_DA_ANON flags
Date: Tue, 8 Mar 2011 14:46:05 +0200 [thread overview]
Message-ID: <1299588365-2749-4-git-send-email-dacohen@gmail.com> (raw)
In-Reply-To: <1299588365-2749-1-git-send-email-dacohen@gmail.com>
Currently IOVMM driver sets IOVMF_DA_FIXED/IOVMF_DA_ANON flags according
to input 'da' address when mapping memory:
da == 0: IOVMF_DA_ANON
da != 0: IOVMF_DA_FIXED
It prevents IOMMU to map first page with fixed 'da'. To avoid such
issue, IOVMM will not automatically set IOVMF_DA_FIXED. It should now
come from the user. IOVMF_DA_ANON will be automatically set if
IOVMF_DA_FIXED isn't set.
Signed-off-by: David Cohen <dacohen@gmail.com>
---
arch/arm/plat-omap/iovmm.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index 11c9b76..dde9cb0 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -654,7 +654,8 @@ u32 iommu_vmap(struct iommu *obj, u32 da, const struct sg_table *sgt,
flags &= IOVMF_HW_MASK;
flags |= IOVMF_DISCONT;
flags |= IOVMF_MMIO;
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags & IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
da = __iommu_vmap(obj, da, sgt, va, bytes, flags);
if (IS_ERR_VALUE(da))
@@ -713,7 +714,8 @@ u32 iommu_vmalloc(struct iommu *obj, u32 da, size_t bytes, u32 flags)
flags &= IOVMF_HW_MASK;
flags |= IOVMF_DISCONT;
flags |= IOVMF_ALLOC;
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags & IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
sgt = sgtable_alloc(bytes, flags, da, 0);
if (IS_ERR(sgt)) {
@@ -803,7 +805,8 @@ u32 iommu_kmap(struct iommu *obj, u32 da, u32 pa, size_t bytes,
flags &= IOVMF_HW_MASK;
flags |= IOVMF_LINEAR;
flags |= IOVMF_MMIO;
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags & IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
da = __iommu_kmap(obj, da, pa, va, bytes, flags);
if (IS_ERR_VALUE(da))
@@ -862,7 +865,8 @@ u32 iommu_kmalloc(struct iommu *obj, u32 da, size_t bytes, u32 flags)
flags &= IOVMF_HW_MASK;
flags |= IOVMF_LINEAR;
flags |= IOVMF_ALLOC;
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags & IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
da = __iommu_kmap(obj, da, pa, va, bytes, flags);
if (IS_ERR_VALUE(da))
--
1.7.0.4
next prev parent reply other threads:[~2011-03-08 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 12:46 [PATCH 0/3] omap: iovmm: Fix IOVMM check for fixed 'da' David Cohen
2011-03-08 12:46 ` [PATCH 1/3] omap: iovmm: disallow mapping NULL address David Cohen
2011-03-08 18:06 ` Guzman Lugo, Fernando
2011-03-08 19:06 ` David Cohen
2011-03-08 19:53 ` Guzman Lugo, Fernando
2011-03-08 20:07 ` David Cohen
2011-03-08 12:46 ` [PATCH 2/3] omap3: change ISP's IOMMU da_start address David Cohen
2011-03-08 14:06 ` Sakari Ailus
2011-03-08 17:15 ` David Cohen
2011-03-08 12:46 ` David Cohen [this message]
2011-03-08 17:59 ` [PATCH 3/3] omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED/IOVMF_DA_ANON flags Guzman Lugo, Fernando
2011-03-08 18:09 ` Hiroshi DOYU
2011-03-08 18:53 ` Guzman Lugo, Fernando
2011-03-08 18:57 ` David Cohen
2011-03-08 19:33 ` Guzman Lugo, Fernando
2011-03-08 19:46 ` David Cohen
2011-03-08 19:51 ` David Cohen
2011-03-08 12:49 ` [PATCH 0/3] omap: iovmm: Fix IOVMM check for fixed 'da' Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299588365-2749-4-git-send-email-dacohen@gmail.com \
--to=dacohen@gmail.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=fernando.lugo@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).