From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel driver addition in the DSS
Date: Wed, 9 Mar 2011 16:23:56 +0200 [thread overview]
Message-ID: <1299680636.2151.96.camel@deskari> (raw)
In-Reply-To: <1299671118-20839-7-git-send-email-mythripk@ti.com>
On Wed, 2011-03-09 at 05:45 -0600, K, Mythri P wrote:
> The panel driver(hdmi_omap4_panel.c) in omap2/dss acts as a controller
> to manage the enable and disable requests and synchronize audio and video.
>
> Signed-off-by: Mythri P K <mythripk@ti.com>
> ---
> drivers/video/omap2/dss/Kconfig | 8 +
> drivers/video/omap2/dss/Makefile | 1 +
> drivers/video/omap2/dss/hdmi_omap4_panel.c | 209 ++++++++++++++++++++++++++++
> 3 files changed, 218 insertions(+), 0 deletions(-)
> create mode 100644 drivers/video/omap2/dss/hdmi_omap4_panel.c
>
> diff --git a/drivers/video/omap2/dss/Kconfig b/drivers/video/omap2/dss/Kconfig
> index 7749ddb..f66043f 100644
> --- a/drivers/video/omap2/dss/Kconfig
> +++ b/drivers/video/omap2/dss/Kconfig
> @@ -125,4 +125,12 @@ config OMAP2_DSS_MIN_FCK_PER_PCK
> Max FCK is 173MHz, so this doesn't work if your PCK
> is very high.
>
> +config OMAP4_PANEL_HDMI
> + bool "HDMI panel support"
> + depends on OMAP2_DSS_HDMI
> + default n
> + help
> + HDMI panel. This adds the High Definition Multimedia panel.
> + See http://www.hdmi.org/ for HDMI specification.
> +
> endif
> diff --git a/drivers/video/omap2/dss/Makefile b/drivers/video/omap2/dss/Makefile
> index 5998b69..7ee4093 100644
> --- a/drivers/video/omap2/dss/Makefile
> +++ b/drivers/video/omap2/dss/Makefile
> @@ -6,3 +6,4 @@ omapdss-$(CONFIG_OMAP2_DSS_VENC) += venc.o
> omapdss-$(CONFIG_OMAP2_DSS_SDI) += sdi.o
> omapdss-$(CONFIG_OMAP2_DSS_DSI) += dsi.o
> omapdss-$(CONFIG_OMAP2_DSS_HDMI) += hdmi.o
> +omapdss-$(CONFIG_OMAP4_PANEL_HDMI) += hdmi_omap4_panel.o
You don't need CONFIG_OMAP4_PANEL_HDMI. In fact, you cannot have it:
hdmi.c calls the panel driver, so they must be compiled in or out
together.
Also, as they depend on each other, adding them in patches like this
breaks compilation. Do it so that first add hdmi.c in a patch. Then
hdmi_omap4_panel.c. After those, add Kconfig and Makefile changes. This
way the kernel stays compilable, and you can still have the additions
divided into separate patches.
Tomi
next prev parent reply other threads:[~2011-03-09 14:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 11:45 [PATCH v4 0/9] OMAP4 : DSS2 : HDMI support on OMAP4 Mythri P K
2011-03-09 11:45 ` [PATCH v4 1/9] OMAP4 : DSS2 : Add display type HDMI to DSS2 Mythri P K
2011-03-09 11:45 ` [PATCH v4 2/9] OMAP4 : DSS2 : HDMI: Select between HDMI VENC clock source Mythri P K
2011-03-09 11:45 ` [PATCH v4 3/9] OMAP4 : DSS2 : HDMI: HDMI dispc gamma table disable Mythri P K
2011-03-09 11:45 ` [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Mythri P K
2011-03-09 11:45 ` [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS Mythri P K
2011-03-09 11:45 ` [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel " Mythri P K
2011-03-09 11:45 ` [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Mythri P K
2011-03-09 11:45 ` [PATCH v4 8/9] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 SDP Mythri P K
2011-03-09 11:45 ` [PATCH v4 9/9] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 PANDA Mythri P K
2011-03-09 15:54 ` [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Premi, Sanjeev
2011-03-10 5:24 ` K, Mythri P
2011-03-09 14:23 ` Tomi Valkeinen [this message]
2011-03-10 5:27 ` [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel driver addition in the DSS K, Mythri P
2011-03-10 7:52 ` Tomi Valkeinen
2011-03-10 9:00 ` K, Mythri P
2011-03-10 9:19 ` Tomi Valkeinen
2011-03-10 9:33 ` K, Mythri P
2011-03-10 9:39 ` Hiremath, Vaibhav
2011-03-10 9:47 ` K, Mythri P
2011-03-10 9:49 ` Tomi Valkeinen
2011-03-09 15:50 ` [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI " Premi, Sanjeev
2011-03-10 5:22 ` K, Mythri P
2011-03-10 7:57 ` Tomi Valkeinen
2011-03-09 15:56 ` [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Premi, Sanjeev
2011-03-10 5:02 ` K, Mythri P
2011-03-10 8:52 ` Premi, Sanjeev
2011-03-10 9:07 ` Tomi Valkeinen
2011-03-09 14:49 ` [PATCH v4 3/9] OMAP4 : DSS2 : HDMI: HDMI dispc gamma table disable Premi, Sanjeev
2011-03-10 5:55 ` K, Mythri P
2011-03-09 14:15 ` [PATCH v4 0/9] OMAP4 : DSS2 : HDMI support on OMAP4 Tomi Valkeinen
2011-03-10 5:27 ` K, Mythri P
2011-03-10 7:21 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299680636.2151.96.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox