Re: [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel driver addition in the DSS

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Wed, 2011-03-09 at 05:45 -0600, K, Mythri P wrote:
> The panel driver(hdmi_omap4_panel.c) in omap2/dss acts as a controller
> to manage the enable and disable requests and synchronize audio and video.
> 
> Signed-off-by: Mythri P K <mythripk@ti.com>

<snip>

> +static int hdmi_panel_probe(struct omap_dss_device *dssdev)
> +{
> +	DSSDBG("ENTER hdmi_panel_probe\n");
> +
> +	dssdev->panel.config = OMAP_DSS_LCD_TFT |
> +			OMAP_DSS_LCD_IVS | OMAP_DSS_LCD_IHS;
> +
> +	/*
> +	 * Initialize the timings to 1920 * 1080
> +	 * This is only for framebuffer update not for TV timing setting
> +	 * Setting TV timing will be done only on enable
> +	 */
> +	dssdev->panel.timings.x_res = 1920;
> +	dssdev->panel.timings.y_res = 1080;

This will cause the framebuffer to be initialized to 1920x1080,
regardless of the timings the hdmi driver will select.

I think you should either probe the display here to find what it
supports, and initialize the size accordingly, or if the display is not
connected, use some safe resolution most of the displays should support.
VGA probably.

And the timings selected here should also be used by the hdmi driver.
What happens now with my monitor is that I get a fb of 1920x1028, but
the hdmi driver doesn't like the modes my monitor gives via EDID, and
falls back to VGA -> messed up display.

Also, I'm getting "timeout waiting for EVSYNC" when I load or unload the
driver.

 Tomi