From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: "Premi, Sanjeev" <premi@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS
Date: Thu, 10 Mar 2011 09:57:49 +0200 [thread overview]
Message-ID: <1299743869.2017.19.camel@deskari> (raw)
In-Reply-To: <AANLkTin69+GHWfG6QHo65G_cpa9Odg3SDf4tgxgdXMyE@mail.gmail.com>
On Wed, 2011-03-09 at 23:22 -0600, K, Mythri P wrote:
> Hi Sanjeev,
>
> On Wed, Mar 9, 2011 at 9:20 PM, Premi, Sanjeev <premi@ti.com> wrote:
> >> -----Original Message-----
> >> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> >> owner@vger.kernel.org] On Behalf Of K, Mythri P
> >> Sent: Wednesday, March 09, 2011 5:15 PM
> >> To: linux-omap@vger.kernel.org; Valkeinen, Tomi
> >> Cc: K, Mythri P
> >> Subject: [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI driver addition in the
> >> DSS
<snip>
> >> +/*
> >> + * Logic for the below structure
> >> + * user enters the CEA or VESA timings by specifying
> >> + * the hdmicode which corresponds to CEA/VESA timings
> >> + * please refer to section 6.3 in HDMI 1.3 specification for timing code.
> >> + * There is a correspondence between CEA/VESA timing and code.
> >> + * In the below structure, cea_vesa_timings corresponds to all
> >> + * The OMAP4 supported timing CEA and VESA timing values.
> >> + * code_cea corresponds to the CEA code entered by the user,
> >> + * The use of it is to get the timing from the cea_vesa_timing array.
> >> + * Similarly for code_vesa.
> >> + * code_index is backmapping, Once EDID is read from the TV
> >> + * EDID is parsed to find the timing values to map it back to the
> >> + * corresponding CEA or VESA index this structure is used.
> >> + */
> >
> > [sp] Is the comment intentionally formatted as it is?
> > There seems to be an opportunity to improve the text and
> > readability here.
> >
> I shall try to indent.
You can just select the whole comment and press "gw", that will arrange
the comment nicely. Presuming you use vim. And everybody does, don't
they? =)
Tomi
next prev parent reply other threads:[~2011-03-10 7:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 11:45 [PATCH v4 0/9] OMAP4 : DSS2 : HDMI support on OMAP4 Mythri P K
2011-03-09 11:45 ` [PATCH v4 1/9] OMAP4 : DSS2 : Add display type HDMI to DSS2 Mythri P K
2011-03-09 11:45 ` [PATCH v4 2/9] OMAP4 : DSS2 : HDMI: Select between HDMI VENC clock source Mythri P K
2011-03-09 11:45 ` [PATCH v4 3/9] OMAP4 : DSS2 : HDMI: HDMI dispc gamma table disable Mythri P K
2011-03-09 11:45 ` [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Mythri P K
2011-03-09 11:45 ` [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS Mythri P K
2011-03-09 11:45 ` [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel " Mythri P K
2011-03-09 11:45 ` [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Mythri P K
2011-03-09 11:45 ` [PATCH v4 8/9] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 SDP Mythri P K
2011-03-09 11:45 ` [PATCH v4 9/9] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 PANDA Mythri P K
2011-03-09 15:54 ` [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Premi, Sanjeev
2011-03-10 5:24 ` K, Mythri P
2011-03-09 14:23 ` [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel driver addition in the DSS Tomi Valkeinen
2011-03-10 5:27 ` K, Mythri P
2011-03-10 7:52 ` Tomi Valkeinen
2011-03-10 9:00 ` K, Mythri P
2011-03-10 9:19 ` Tomi Valkeinen
2011-03-10 9:33 ` K, Mythri P
2011-03-10 9:39 ` Hiremath, Vaibhav
2011-03-10 9:47 ` K, Mythri P
2011-03-10 9:49 ` Tomi Valkeinen
2011-03-09 15:50 ` [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI " Premi, Sanjeev
2011-03-10 5:22 ` K, Mythri P
2011-03-10 7:57 ` Tomi Valkeinen [this message]
2011-03-09 15:56 ` [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Premi, Sanjeev
2011-03-10 5:02 ` K, Mythri P
2011-03-10 8:52 ` Premi, Sanjeev
2011-03-10 9:07 ` Tomi Valkeinen
2011-03-09 14:49 ` [PATCH v4 3/9] OMAP4 : DSS2 : HDMI: HDMI dispc gamma table disable Premi, Sanjeev
2011-03-10 5:55 ` K, Mythri P
2011-03-09 14:15 ` [PATCH v4 0/9] OMAP4 : DSS2 : HDMI support on OMAP4 Tomi Valkeinen
2011-03-10 5:27 ` K, Mythri P
2011-03-10 7:21 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299743869.2017.19.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox