From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "K, Mythri P" <mythripk@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition
Date: Thu, 10 Mar 2011 11:07:32 +0200 [thread overview]
Message-ID: <1299748052.2017.52.camel@deskari> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024C19269B@dbde02.ent.ti.com>
On Thu, 2011-03-10 at 02:52 -0600, Premi, Sanjeev wrote:
> > -----Original Message-----
> > From: K, Mythri P
> > Sent: Thursday, March 10, 2011 10:32 AM
> > To: Premi, Sanjeev
> > Cc: linux-omap@vger.kernel.org; Valkeinen, Tomi
> > Subject: Re: [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file
> > addition
> >
>
> [snip]...[snip]
>
> > >
> > > [sp] Any specific reason to keep header file in separate patch?
> > >
> > When i had posted it earlier there were several compliants that the
> > patch is huge,
> > if i include header file with the corresponding c file , and hence
> > difficult to review. So it just to make
> > reviewers job easy.
>
> [sp] Final say on the issue rests with the maintainer. But it I found it
> difficult to review the .c file with when looking for structure
> definitions, members etc.
>
> If they were together, we wouldn't need this in a separate patch:
> [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to...
It's not a clear thing, but I find it easier to review the patches, if
new large files are added as separate patches.
But it's true that that introduces the need to do some cross checking
between patches, so it's a compromise.
Tomi
next prev parent reply other threads:[~2011-03-10 9:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 11:45 [PATCH v4 0/9] OMAP4 : DSS2 : HDMI support on OMAP4 Mythri P K
2011-03-09 11:45 ` [PATCH v4 1/9] OMAP4 : DSS2 : Add display type HDMI to DSS2 Mythri P K
2011-03-09 11:45 ` [PATCH v4 2/9] OMAP4 : DSS2 : HDMI: Select between HDMI VENC clock source Mythri P K
2011-03-09 11:45 ` [PATCH v4 3/9] OMAP4 : DSS2 : HDMI: HDMI dispc gamma table disable Mythri P K
2011-03-09 11:45 ` [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Mythri P K
2011-03-09 11:45 ` [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS Mythri P K
2011-03-09 11:45 ` [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel " Mythri P K
2011-03-09 11:45 ` [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Mythri P K
2011-03-09 11:45 ` [PATCH v4 8/9] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 SDP Mythri P K
2011-03-09 11:45 ` [PATCH v4 9/9] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 PANDA Mythri P K
2011-03-09 15:54 ` [PATCH v4 7/9] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Premi, Sanjeev
2011-03-10 5:24 ` K, Mythri P
2011-03-09 14:23 ` [PATCH v4 6/9] OMAP4 : DSS2 : HDMI: HDMI panel driver addition in the DSS Tomi Valkeinen
2011-03-10 5:27 ` K, Mythri P
2011-03-10 7:52 ` Tomi Valkeinen
2011-03-10 9:00 ` K, Mythri P
2011-03-10 9:19 ` Tomi Valkeinen
2011-03-10 9:33 ` K, Mythri P
2011-03-10 9:39 ` Hiremath, Vaibhav
2011-03-10 9:47 ` K, Mythri P
2011-03-10 9:49 ` Tomi Valkeinen
2011-03-09 15:50 ` [PATCH v4 5/9] OMAP4 : DSS2 : HDMI: HDMI " Premi, Sanjeev
2011-03-10 5:22 ` K, Mythri P
2011-03-10 7:57 ` Tomi Valkeinen
2011-03-09 15:56 ` [PATCH v4 4/9] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Premi, Sanjeev
2011-03-10 5:02 ` K, Mythri P
2011-03-10 8:52 ` Premi, Sanjeev
2011-03-10 9:07 ` Tomi Valkeinen [this message]
2011-03-09 14:49 ` [PATCH v4 3/9] OMAP4 : DSS2 : HDMI: HDMI dispc gamma table disable Premi, Sanjeev
2011-03-10 5:55 ` K, Mythri P
2011-03-09 14:15 ` [PATCH v4 0/9] OMAP4 : DSS2 : HDMI support on OMAP4 Tomi Valkeinen
2011-03-10 5:27 ` K, Mythri P
2011-03-10 7:21 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299748052.2017.52.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox