Re: [PATCH v5 05/10] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Thu, 2011-03-10 at 04:44 -0600, K, Mythri P wrote:
> Adding the hdmi interface driver(hdmi.c) to the dss driver.
> It configures the audio and video portion of HDMI based on
> functionality called by the  panel driver.
> 
> Signed-off-by: Mythri P K <mythripk@ti.com>
>                 Yong Zhi <y-zhi@ti.com>

This isn't the correct way to have signed off. Each person should be in
its own signed-off-by: line.

<snip>

> +/*
> + * Logic for the below structure :
> + * user enters the CEA or VESA timings by specifying the HDMI/DVI code.
> + * There is a correspondence between CEA/VESA timing and code , Please
> + * refer to section 6.3 in HDMI 1.3 specification for timing code.
> + * In the below structure, cea_vesa_timings corresponds to all OMAP4
> + * supported CEA and VESA timing values.
> + * code_cea corresponds to the CEA code , It is used to get the timing
> + * from cea_vesa_timing array. Similarly with code_vesa.
> + * code_index is used for back mapping, That is once EDID is read from
> + * the TV, EDID is parsed to find the timing values and then map it to
> + * corresponding CEA or VESA index.
> + */

This comment is still rather messy. Check capital letters, periods,
spaces before commas. Also, if you divide text into paragraphs, use an
empty line between the paragraphs. If you don't divide into paragraphs,
then the text should be evenly formatted.

 Tomi