From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Taneja, Archit" <archit@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] OMAP2PLUS: DSS2: FEATURES: Fix usage of dss_reg_field and dss_clk_source_name
Date: Tue, 15 Mar 2011 11:57:22 +0530 [thread overview]
Message-ID: <1300170442.1946.15.camel@lappyti> (raw)
In-Reply-To: <1300163303-31662-1-git-send-email-archit@ti.com>
On Mon, 2011-03-14 at 23:28 -0500, Taneja, Archit wrote:
> The structures dss_reg_field and dss_clk_source_name have enum members which
> specify the register field and the clock source respectively. These members are
> not used to choose the correct result in the corresponding feature functions.
> Remove these members and change the features array declaration to incorporate
> these enums.
>
> The structure dss_clk_source_name without the enum member is just a pointer to
> an string. Remove the structure and use a character pointer directly.
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> drivers/video/omap2/dss/dss.c | 10 ++--
> drivers/video/omap2/dss/dss.h | 6 ---
> drivers/video/omap2/dss/dss_features.c | 77 ++++++++++++++++----------------
> 3 files changed, 43 insertions(+), 50 deletions(-)
Thanks, looks good to me.
Tomi
prev parent reply other threads:[~2011-03-15 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 4:28 [PATCH] OMAP2PLUS: DSS2: FEATURES: Fix usage of dss_reg_field and dss_clk_source_name Archit Taneja
2011-03-15 4:28 ` [PATCH] OMAP: DSS2: FEATURES: Functions to return min and max values of parameters Archit Taneja
2011-03-15 7:09 ` Tomi Valkeinen
2011-03-15 4:28 ` [PATCH v2] OMAP: DSS2: FEATURES: DSI PLL parameter cleanup Archit Taneja
2011-03-15 7:11 ` Tomi Valkeinen
2011-03-15 6:27 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300170442.1946.15.camel@lappyti \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).