Re: [PATCH] OMAP: DSS2: FEATURES: Functions to return min and max values of parameters

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

On Mon, 2011-03-14 at 23:28 -0500, Taneja, Archit wrote:
> Create 2 functions dss_feat_get_param_min() and dss_feat_get_param_max() which
> return the minimum and maximum value of a parameter. Introduce a enum in
> dss_features called dss_range_param which contains parameters whose ranges we
> are interested in.
> 
> Replace this with dss_feat_get_max_dss_fck() which is specific to the parameter
> DSS_FCK.
> 
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> Note: Applies over:
> 
> http://gitorious.org/linux-omap-dss2/linux/commits/master
> 
> and the patch submitted on linux-omap:
> OMAP2PLUS: DSS2: FEATURES: Fix usage of dss_reg_field and dss_clk_source_name
> 
>  drivers/video/omap2/dss/dsi.c          |    2 +-
>  drivers/video/omap2/dss/dss.c          |    2 +-
>  drivers/video/omap2/dss/dss_features.c |   36 ++++++++++++++++++++++++-------
>  drivers/video/omap2/dss/dss_features.h |    7 +++++-
>  4 files changed, 36 insertions(+), 11 deletions(-)

Thanks, looks good.

For future, usually in patches like this it would be good to explain in
the description the reason why this is made (well, it would be good
always to explain "why"). The patch alone doesn't really make sense,
only when the patch about DSI PLL parameters is applied it makes sense.

 Tomi