From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "K, Mythri P" <mythripk@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v5 00/10] OMAP4 : DSS2 : HDMI support on OMAP4
Date: Wed, 16 Mar 2011 14:02:12 +0530 [thread overview]
Message-ID: <1300264332.1917.87.camel@lappyti> (raw)
In-Reply-To: <AANLkTik7kaMDMrL_AweAY0dCo7wxaaHkQxTcmMfVB-=f@mail.gmail.com>
On Fri, 2011-03-11 at 02:24 -0600, K, Mythri P wrote:
> Hi Tomi,
>
> On Thu, Mar 10, 2011 at 8:36 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > There is this code in dss.c:
> >
> > #ifdef CONFIG_OMAP2_DSS_VENC
> > REG_FLD_MOD(DSS_CONTROL, 1, 4, 4); /* venc dac demen */
> > REG_FLD_MOD(DSS_CONTROL, 1, 3, 3); /* venc clock 4x enable */
> > REG_FLD_MOD(DSS_CONTROL, 0, 2, 2); /* venc clock mode = normal */
> > #endif
> >
> Regarding this piece of code , although it appears that is should not affect ,
> I think we should move this out of dss_init , if any such change is needed
> we should do that on VENC enable dont you think ?
Either we should enable them on venc_enable, or remove the ifdef. If
there are side effects (which we don't know currently) we should use do
them on venc_enable. If there aren't any side effects, we should just
write the register always.
Tomi
prev parent reply other threads:[~2011-03-16 8:32 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 10:44 [PATCH v5 00/10] OMAP4 : DSS2 : HDMI support on OMAP4 Mythri P K
2011-03-10 10:44 ` [PATCH v5 01/10] OMAP4 : DSS2 : Add display type HDMI to DSS2 Mythri P K
2011-03-10 10:44 ` [PATCH v5 02/10] OMAP4 : DSS2 : HDMI: Select between HDMI VENC clock source Mythri P K
2011-03-10 10:44 ` [PATCH v5 03/10] OMAP4 : DSS2 : HDMI: Dispc gamma enable set/reset function for TV Mythri P K
2011-03-10 10:44 ` [PATCH v5 04/10] OMAP4 : DSS2 : HDMI: HDMI driver header file addition Mythri P K
2011-03-10 10:44 ` [PATCH v5 05/10] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS Mythri P K
2011-03-10 10:44 ` [PATCH v5 06/10] OMAP4 : DSS2 : HDMI: HDMI panel " Mythri P K
2011-03-10 10:44 ` [PATCH v5 07/10] OMAP4 : DSS2 : HDMI: Add makefile and kconfig changes to enable HDMI in OMAP4 Mythri P K
2011-03-10 10:44 ` [PATCH v5 08/10] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Mythri P K
2011-03-10 10:44 ` [PATCH v5 09/10] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 SDP Mythri P K
2011-03-10 10:44 ` [PATCH v5 10/10] OMAP4 : HDMI : Add HDMI structure in the board file for OMAP4 PANDA Mythri P K
2011-03-15 4:23 ` Tomi Valkeinen
2011-03-15 14:47 ` John S
2011-03-10 14:04 ` [PATCH v5 08/10] OMAP4 : DSS : HDMI: Call to HDMI module init to register driver Tomi Valkeinen
2011-03-10 13:59 ` [PATCH v5 07/10] OMAP4 : DSS2 : HDMI: Add makefile and kconfig changes to enable HDMI in OMAP4 Tomi Valkeinen
2011-03-10 13:58 ` [PATCH v5 05/10] OMAP4 : DSS2 : HDMI: HDMI driver addition in the DSS Tomi Valkeinen
2011-03-10 13:52 ` [PATCH v5 03/10] OMAP4 : DSS2 : HDMI: Dispc gamma enable set/reset function for TV Tomi Valkeinen
2011-05-05 13:50 ` Laurent Pinchart
2011-03-10 13:49 ` [PATCH v5 02/10] OMAP4 : DSS2 : HDMI: Select between HDMI VENC clock source Tomi Valkeinen
2011-03-10 13:48 ` [PATCH v5 01/10] OMAP4 : DSS2 : Add display type HDMI to DSS2 Tomi Valkeinen
2011-03-10 16:53 ` Aaro Koskinen
2011-03-10 13:44 ` [PATCH v5 00/10] OMAP4 : DSS2 : HDMI support on OMAP4 Tomi Valkeinen
2011-03-10 14:45 ` Stephan Raue
2011-03-10 14:51 ` Tomi Valkeinen
2011-03-11 0:07 ` Stephan Raue
2011-03-11 6:16 ` K, Mythri P
2011-03-11 7:24 ` Tomi Valkeinen
2011-03-11 13:23 ` Hiremath, Vaibhav
2011-03-14 8:35 ` Hiremath, Vaibhav
2011-03-14 9:24 ` Tomi Valkeinen
2011-03-14 9:35 ` Hiremath, Vaibhav
2011-03-16 6:45 ` Tomi Valkeinen
2011-03-16 6:47 ` Hiremath, Vaibhav
2011-03-11 7:12 ` Tomi Valkeinen
2011-03-11 8:43 ` Stephan Raue
2011-03-11 13:22 ` Tomi Valkeinen
2011-03-11 16:18 ` Stephan Raue
2011-03-11 18:27 ` Tomi Valkeinen
2011-03-11 18:42 ` Stephan Raue
2011-03-12 6:51 ` K, Mythri P
2011-03-13 14:32 ` Stephan Raue
2011-03-13 16:20 ` Stephan Raue
2011-03-16 6:51 ` Tomi Valkeinen
2011-03-16 10:53 ` K, Mythri P
2011-03-16 10:59 ` Tomi Valkeinen
2011-03-16 23:49 ` Stephan Raue
2011-03-17 11:11 ` Tomi Valkeinen
2011-03-17 16:20 ` Janorkar, Mayuresh
2011-03-17 20:16 ` Stephan Raue
2011-03-17 21:13 ` Stephan Raue
2011-03-17 21:34 ` Stephan Raue
2011-03-18 3:45 ` Tomi Valkeinen
2011-03-18 5:43 ` Anand Gadiyar
2011-03-18 5:43 ` Anand Gadiyar
2011-03-18 6:17 ` Gadiyar, Anand
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-18 5:52 ` Anand Gadiyar
2011-03-14 10:37 ` Jan, Sebastien
2011-03-15 4:06 ` Tomi Valkeinen
2011-03-15 4:38 ` K, Mythri P
2011-03-10 15:06 ` Tomi Valkeinen
2011-03-11 8:24 ` K, Mythri P
2011-03-16 8:32 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300264332.1917.87.camel@lappyti \
--to=tomi.valkeinen@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=mythripk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).