From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <archit@ti.com>, tony@atomide.com
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP4: DSS2: Add Panel Taal device struct in 4430sdp board file
Date: Wed, 30 Mar 2011 10:02:41 +0300 [thread overview]
Message-ID: <1301468561.2333.86.camel@deskari> (raw)
In-Reply-To: <1301390798-22951-1-git-send-email-archit@ti.com>
On Tue, 2011-03-29 at 14:56 +0530, Archit Taneja wrote:
> Panel Taal is a DSI panel connected to the DSI1 lanes on 4430sdp and Blaze.
> Add omap_dss_device struct for Panel Taal in the 4430sdp board file. This
> represents the primary lcd device on 4430sdp board and Blaze board. The
> following things are done:
> -Add regulator consumers (vdds_dsi) for the VCXIO supply. VCXIO on blaze and
> 4430sdp is a regulator supply for dsi, csi2, usb otg, and the DPLLs of mpu, iva
> and audio core. Since VCXIO has no consumers declared and the mpu's DPLL is also
> powered by it, set the always_on flag for the regulator so that VCXIO is never
> shut off accidentally.
> -Remove dummy lcd platform_device.
> -Add dsi_set_backlight() routine, original routine was written by Vikram Pandita.
> -Mux settings for DSI1 lanes, GPIO initialisations for Taal reset and Backlight.
>
> Signed-off-by: Archit Taneja <archit@ti.com>
> ---
> Note:
> Can be tested with the tree:
> http://gitorious.org/~boddob/linux-omap-dss2/archit-dss2-clone
>
> arch/arm/mach-omap2/board-4430sdp.c | 132 +++++++++++++++++++++++++++++++---
> 1 files changed, 120 insertions(+), 12 deletions(-)
Looks good to me. I think I can take this to my tree, and see if I can
get this and the few DSS bug fixes in for rc2.
Tony, can you ack this if it looks ok for you?
Tomi
prev parent reply other threads:[~2011-03-30 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 9:26 [PATCH] OMAP4: DSS2: Add Panel Taal device struct in 4430sdp board file Archit Taneja
2011-03-30 7:02 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301468561.2333.86.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox