From: Jarkko Nikula <jhnikula@gmail.com>
To: linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>, Felipe Balbi <balbi@ti.com>,
Jarkko Nikula <jhnikula@gmail.com>
Subject: [PATCH 1/3] cbus: tahvo: Fix build breakage caused by deprecated initializer removal
Date: Mon, 18 Apr 2011 22:21:30 +0300 [thread overview]
Message-ID: <1303154492-13520-1-git-send-email-jhnikula@gmail.com> (raw)
Use DEFINE_SPINLOCK() for static spinlock initialization as the commit
d04fa5a "locking: Remove deprecated lock initializers" removes the
deprecated SPIN_LOCK_UNLOCKED. Since tahvo_lock is not used elsewhere than
tahvo.c it can be removed from tahvo.h too.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
drivers/cbus/tahvo.c | 2 +-
drivers/cbus/tahvo.h | 2 --
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c
index 8e2e669..45318d9 100644
--- a/drivers/cbus/tahvo.c
+++ b/drivers/cbus/tahvo.c
@@ -53,7 +53,7 @@ static int tahvo_initialized;
static int tahvo_is_betty;
static struct tasklet_struct tahvo_tasklet;
-spinlock_t tahvo_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(tahvo_lock);
struct tahvo_irq_handler_desc {
int (*func)(unsigned long);
diff --git a/drivers/cbus/tahvo.h b/drivers/cbus/tahvo.h
index 6cb6600..e5ed990 100644
--- a/drivers/cbus/tahvo.h
+++ b/drivers/cbus/tahvo.h
@@ -63,6 +63,4 @@ int tahvo_get_backlight_level(void);
int tahvo_get_max_backlight_level(void);
void tahvo_set_backlight_level(int level);
-extern spinlock_t tahvo_lock;
-
#endif /* __DRIVERS_CBUS_TAHVO_H */
--
1.7.0.4
next reply other threads:[~2011-04-18 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 19:21 Jarkko Nikula [this message]
2011-04-18 19:21 ` [PATCH 2/3] cbus: retu: Fix build breakage caused by recent genirq commits Jarkko Nikula
2011-04-18 19:21 ` [PATCH 3/3] omap: Fix board-nokia770.c and board-n8x0 cbus build breakage Jarkko Nikula
2011-04-19 7:07 ` [PATCH 1/3] cbus: tahvo: Fix build breakage caused by deprecated initializer removal Tony Lindgren
2011-04-19 7:53 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303154492-13520-1-git-send-email-jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox