RE: [PATCH 4/7] OMAP: DSS: Add i2c client driver for picodlp

Janorkar, Mayuresh
2011-04-21T11:09:17Z

> -----Original Message-----
> From: Valkeinen, Tomi
> Sent: Tuesday, April 19, 2011 5:12 PM
> To: Janorkar, Mayuresh
> Cc: linux-omap@vger.kernel.org; K, Mythri P
> Subject: Re: [PATCH 4/7] OMAP: DSS: Add i2c client driver for picodlp
>
> On Mon, 2011-04-18 at 11:45 +0530, Mayuresh Janorkar wrote:
> > The configurations and data transfer with picodlp panel happens through
> i2c.
> > An i2c client with name "picodlp_i2c_driver" is registered inside panel.
> >
> > Signed-off-by: Mythri P K <mythripk@ti.com>
> > Signed-off-by: Mayuresh Janorkar <mayur@ti.com>
> > Signed-off-by: Mythri P K <mythripk@ti.com>
> > ---
> > drivers/video/omap2/displays/panel-picodlp.c | 130
> +++++++++++++++++++++++++-
> > 1 files changed, 126 insertions(+), 4 deletions(-)
>
> <snip>
>
> > @@ -65,8 +131,10 @@ static int picodlp_panel_power_on(struct
> omap_dss_device *dssdev)
> > msleep(675);
> > dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
> >
> > - return 0;
> > + picodlp_i2c_data =
> > + i2c_get_clientdata(picod->picodlp_i2c_client);
>
> This variable is not used at all.

Not in this patch but it is used in next patch.
I would add it as a part of next patch where it is used.

>
> Tomi
>