From: Kevin Hilman <khilman@ti.com>
To: linux-omap@vger.kernel.org
Cc: charu@ti.com
Subject: [PATCH 1/9] OMAP: GPIO: _clear_gpio_irqbank: fix flushing of posted write
Date: Thu, 21 Apr 2011 13:35:19 -0700 [thread overview]
Message-ID: <1303418127-4310-2-git-send-email-khilman@ti.com> (raw)
In-Reply-To: <1303418127-4310-1-git-send-email-khilman@ti.com>
In commit 78a1a6d3411de1a8b0dc1cb92754b5f12f251912 (ARM: OMAP4: Update
the GPIO support) braces were mistakenly added to included the
register read-back inside the cpu_is_* checking.
Remove the braces, ensuring that a register read-back is done, even
when the IRQSTATUS2 register is not written.
Note that the register read-back might be IRQSTATUS1 or IRQSTATUS2
depending on the CPU, but a read-back of any register in that region
will cause a flush of the posted writes.
Signed-off-by: Kevin Hilman <khilman@ti.com>
---
arch/arm/plat-omap/gpio.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index d2adcdd..fe6971a 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -813,12 +813,11 @@ static void _clear_gpio_irqbank(struct gpio_bank *bank, int gpio_mask)
else if (cpu_is_omap44xx())
reg = bank->base + OMAP4_GPIO_IRQSTATUS1;
- if (cpu_is_omap24xx() || cpu_is_omap34xx() || cpu_is_omap44xx()) {
+ if (cpu_is_omap24xx() || cpu_is_omap34xx() || cpu_is_omap44xx())
__raw_writel(gpio_mask, reg);
/* Flush posted write for the irq status to avoid spurious interrupts */
__raw_readl(reg);
- }
}
static inline void _clear_gpio_irqstatus(struct gpio_bank *bank, int gpio)
--
1.7.4
next prev parent reply other threads:[~2011-04-21 20:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 20:35 [PATCH 0/9] OMAP: GPIO: cleanup, consolidation, etc. (v2) Kevin Hilman
2011-04-21 20:35 ` Kevin Hilman [this message]
2011-04-21 20:35 ` [PATCH 2/9] OMAP: GPIO: remove MPUIO handling from _clear_gpio_irqbank() Kevin Hilman
2011-04-21 20:35 ` [PATCH 3/9] OMAP: GPIO: move bank width into struct gpio_bank Kevin Hilman
2011-04-21 20:35 ` [PATCH 4/9] OMAP: GPIO: _get_gpio_irqbank_mask: replace hard-coded mask with bank->width Kevin Hilman
2011-04-21 20:35 ` [PATCH 5/9] OMAP: GPIO: move register offset defines into gpio.h Kevin Hilman
2011-04-21 20:35 ` [PATCH 6/9] OMAP: GPIO: consolidate direction, input, output, remove #ifdefs Kevin Hilman
2011-04-21 20:35 ` [PATCH 7/9] OMAP: GPIO: consolidate IRQ status handling, " Kevin Hilman
2011-04-21 20:35 ` [PATCH 8/9] OMAP: GPIO: conslidate enable/disable of GPIO IRQs, remove ifdefs Kevin Hilman
2011-04-21 20:35 ` [PATCH 9/9] OMAP: GPIO: convert MPUIO IRQ over to generic irq_chip Kevin Hilman
2011-04-25 7:27 ` [PATCH 0/9] OMAP: GPIO: cleanup, consolidation, etc. (v2) DebBarma, Tarun Kanti
2011-04-25 8:29 ` DebBarma, Tarun Kanti
2011-05-03 16:25 ` Kevin Hilman
2011-04-28 9:39 ` Varadarajan, Charulatha
2011-05-04 1:04 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303418127-4310-2-git-send-email-khilman@ti.com \
--to=khilman@ti.com \
--cc=charu@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox